Repository navigation
Pin the country smoke bundle to policyengine-us 2.42.13 - #620
Merged
Merged
Conversation
The pinned policyengine-us 1.824.1 has been deleted from PyPI, so every "Test Core and country packages" job failed to install. US 2.42.13 is the newest release; it requires spm-calculator>=1.0.0,<=1.0.0.post1, so the SPM pin moves to 1.0.0.post1. The UK pin is unchanged. Fixes #619. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #619
Change
.github/requirements/legacy-country-smoke.txt:policyengine-usspm-calculatorpolicyengine-ukspm-calculator>=1.0.0,<=1.0.0.post1, so the old 0.3.1 pin would conflict. 1.0.0.post1 is the release the new US pin resolves to.pr.yamlno longer refers to a legacy US model; this is a comment-only change.Old policyengine-us releases are deleted from PyPI as space is needed, so this exact pin will need moving again. #619 lists the options.
Validation
I ran the job's steps locally on Python 3.11 and 3.14 (macOS), with no Hugging Face or GitHub token available:
uv pip install . -r .github/requirements/legacy-country-smoke.txt "pytest-rerunfailures>=16.2,<17"resolves 84 packages, with Core installed from the checkout.uv pip checkreports every installed package compatible.RUN_SMOKE_TESTS=0 python -m pytest -m smoke --reruns 2 --reruns-delay 5 -v -sgives 2 passed: the US and UK tax-benefit systems both initialise. 24 tests are skipped, including the microsimulation smoke test, whichRUN_SMOKE_TESTS=0disables, as it did before.actionlintpasses onpr.yaml.Not run locally: Windows, and Python 3.12 and 3.13. This PR's CI covers them.
Environment variables
No environment variable or secret is added, removed or rewired. The changed job reads two:
RUN_SMOKE_TESTS: set to the literal"0"in the "Run smoke tests only" step'senv. It's the only variable the smoke tests read.POLICYENGINE_GITHUB_MICRODATA_AUTH_TOKEN:${{ secrets.GITHUB_TOKEN }}, GitHub Actions' built-in token, passed in through the same step'senv. Only the skipped microsimulation test would use it.🤖 Generated with Claude Code