Skip to content

Fix RCE Vulnerability - #9105

Open
nolanpro wants to merge 1 commit into
developfrom
task/FOUR-33979
Open

nolanpro wants to merge 1 commit into
developfrom
task/FOUR-33979

Conversation

@nolanpro

Copy link
Copy Markdown
Contributor

ci:deploy

@cursor

cursor Bot commented Oct 16, 2026 •

Copy link
Copy Markdown

PR Summary

Low Risk
Security fix that narrows cancel behavior to expected temp PID files; low residual risk if callers pass valid paths from the build flow.

Overview
Hardens the script-executor cancel API against command injection and arbitrary file read by no longer trusting raw pidFile input.

The endpoint now requires the same admin/custom-executor auth as other script-executor APIs, validates pidFile, and reads the PID only from paths matching /tmp/build_script_executor_* under /tmp with a numeric PID. kill is invoked via sprintf('kill -9 %d', $pid) instead of interpolating unvalidated shell content.

Reviewed by Cursor Bugbot for commit 126e5fc. Bugbot is set up for automated code reviews on this repo. Configure here.

@decisions-sonarqube

Copy link
Copy Markdown

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@gusys gusys left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@vladyrichter

Copy link
Copy Markdown

QA server K8S was successfully deployed https://tenant-1.ci-f7a31ba3c6.engk8s.processmaker.net

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants