Repository navigation
[Artifact 1556] しゃぼんリングの作成 - #2062
Open
ogachu0331 wants to merge 19 commits into
Open
ogachu0331 wants to merge 19 commits into
ogachu0331 wants to merge 19 commits into
Conversation
Lapis-LJA
reviewed
Jun 14, 2026
Lapis-LJA
requested changes
Jun 14, 2026
…SB/Asset into dev/ogachu_artifact1556
Lapis-LJA
requested changes
Oct 3, 2026
Comment on lines
+9
to
+15
| execute if score @s 178.Tick matches 1 run function asset:effect/0378.bubble_shoot/tick/vfx/1 | ||
| # しゃぼんを軌跡に沿って召喚 | ||
| execute if score @s 178.Tick matches 1 positioned ^-1.7 ^1.8 ^1.2 run function asset:effect/0378.bubble_shoot/tick/summon | ||
| execute if score @s 178.Tick matches 2 positioned ^-0.85 ^1.6 ^1.2 run function asset:effect/0378.bubble_shoot/tick/summon | ||
| execute if score @s 178.Tick matches 3 positioned ^0 ^1.4 ^1.2 run function asset:effect/0378.bubble_shoot/tick/summon | ||
| execute if score @s 178.Tick matches 4 positioned ^0.85 ^1.2 ^1.2 run function asset:effect/0378.bubble_shoot/tick/summon | ||
| execute if score @s 178.Tick matches 5 positioned ^1.7 ^1.0 ^1.2 run function asset:effect/0378.bubble_shoot/tick/summon |
Contributor
There was a problem hiding this comment.
フィールドを使えば専用のスコアは不要になるかも？
コレはお好みで
Comment on lines
+16
to
+23
| playsound minecraft:entity.item.pickup player @a ~ ~ ~ 1 1.6 | ||
| playsound minecraft:entity.chicken.egg player @a ~ ~ ~ 1 1.3 | ||
| playsound minecraft:entity.slime.jump player @a ~ ~ ~ 1 2.0 | ||
| playsound minecraft:block.honey_block.break player @a ~ ~ ~ 1 2.0 | ||
| playsound minecraft:entity.turtle.egg_crack player @a ~ ~ ~ 1 2.0 | ||
| playsound minecraft:entity.experience_orb.pickup player @a ~ ~ ~ 0.2 1.5 | ||
| # 弾けた時の水しぶきの音 | ||
| playsound minecraft:entity.player.splash neutral @a ~ ~ ~ 0.4 2.0 0 |
Contributor
There was a problem hiding this comment.
playerとneutralが混ざっている
おそらくneutralに統一するのがよい
Comment on lines
+11
to
+13
| # 16..の時、常時追尾 | ||
| #execute if score @s General.Object.Tick matches 16.. run tp @s ~ ~ ~ facing entity @e[type=#lib:living_without_player,tag=Enemy,tag=!Uninterferable,distance=..20,sort=nearest,limit=1] eyes | ||
| #execute if score @s General.Object.Tick matches 16.. facing entity @e[type=#lib:living_without_player,distance=..20,sort=nearest,limit=1] eyes positioned ^ ^ ^-100 rotated as @s positioned ^ ^ ^-600 facing entity @s eyes positioned as @s run tp @s ~ ~ ~ ~ ~ |
| execute if score @s General.Object.Tick matches 8.. run function asset:object/1165.bubble_spreader/tick/homing | ||
|
|
||
| # super.tick | ||
| function asset:object/super.tick |
Contributor
There was a problem hiding this comment.
Suggested change
| function asset:object/super.tick | |
| execute at @s run function asset:object/super.tick |
Lapis-LJA
requested changes
Oct 17, 2026
|
|
||
| # 弾を召喚 | ||
| data modify storage api: Argument.ID set value 1165 | ||
| data modify storage api: Argument.FieldOverride.Damage set value 150f |
| # 弾を召喚 | ||
| data modify storage api: Argument.ID set value 1165 | ||
| data modify storage api: Argument.FieldOverride.Damage set value 150f | ||
| data modify storage api: Argument.FieldOverride.AdditionalMPHeal set from storage api: PersistentArgument.AdditionalMPHeal |
Contributor
There was a problem hiding this comment.
PersistentArgumentはエフェクト側じゃ取得できないので、神器側でフィールドに入れてからここで取得してね
| execute positioned ^ ^ ^3 run tag @e[type=#lib:living_without_player,tag=Enemy,tag=!Uninterferable,distance=..5] add 1165.TargetCandidate | ||
| execute unless entity @e[type=#lib:living_without_player,tag=1165.TargetCandidate,distance=..10] positioned ^ ^ ^15 run tag @e[type=#lib:living_without_player,tag=Enemy,tag=!Uninterferable,distance=..10] add 1165.TargetCandidate | ||
| execute facing entity @e[type=#lib:living_without_player,tag=1165.TargetCandidate,distance=..25,sort=nearest,limit=1] eyes positioned ^ ^ ^-140 rotated as @s positioned ^ ^ ^-800 facing entity @s feet positioned as @s run tp @s ~ ~ ~ ~ ~ | ||
| execute run tag @e[type=#lib:living_without_player,tag=1165.TargetCandidate,distance=..30] remove 1165.TargetCandidate |
Contributor
There was a problem hiding this comment.
execute run に意味はなさそう
Suggested change
| execute run tag @e[type=#lib:living_without_player,tag=1165.TargetCandidate,distance=..30] remove 1165.TargetCandidate | |
| tag @e[type=#lib:living_without_player,tag=1165.TargetCandidate,distance=..30] remove 1165.TargetCandidate |
Comment on lines
+6
to
+11
|
|
||
| # General.Object.Tickによって挙動を変える | ||
| # 一定時間まで 反射 | ||
| execute if score @s General.Object.Tick matches ..100 run function asset:object/1165.bubble_spreader/hit_block/reflect | ||
| # それ以後 消滅 | ||
| execute if score @s General.Object.Tick matches 100.. run function asset:object/call.m {method:kill} |
Contributor
There was a problem hiding this comment.
Rangeが65に設定されているので、General.Object.Tickが100以上になることはないため、この分岐は不要
Comment on lines
+6
to
+7
|
|
||
|
|
Contributor
There was a problem hiding this comment.
これは任せるけど、ちょっと無駄な改行があるのは変かも...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
神器とそれに必要なobject1165の作成