Repository navigation
feat: check for existing PRs / branches before diagnosing an issue — 3.3.0 (#366) - #373
Merged
Merged
Conversation
…the issue before diagnosing it — 3.3.0 (#366) `/idd-all #N` on an issue an open PR already implements used to diagnose and implement it again on a new `idd/N-*` branch; the only issue→PR lookup was idd-close Step 1.5, at the end. `scripts/check-existing-work.sh` answers the question for every issue in one call (PR lists fetched once, `git fetch` plus remote-tracking refs for branches) and returns a verdict per issue: blocked / resume / unknown / clear. idd-all, idd-all-chain, idd-diagnose, idd-implement and idd-close consult it; `references/pr-issue-matching.md` documents the matching. New suite `check-existing-work`; Spectra change `add-existing-work-lookup` (13/13 tasks). Written by another session; moved off PR #318's branch onto main and committed here without an /idd-verify run, by maintainer decision. The [Unreleased] CHANGELOG section becomes 3.3.0. Refs #366
…n answer (#366) Found by a security review of PR #373 before merge. - The four starting/diagnosing skills fell back to `EW_JSON=""` when the helper crashed. jq prints nothing for empty input, so `// "unknown"` never ran and the verdict came out empty ("verdict= "), which no row of the table covers. They now fall back to `{}`, which yields `unknown`. - idd-close Step 1.5 passed when `gh issue view` failed: the helper needs the issue's creation time to match PRs, so the issue had no evidence and an open PR declaring it was treated as absent. The gate now refuses then too. The check-existing-work suite now executes each skill's own snippet (crashed helper → verdict=unknown; unreadable issue + declaring open PR → idd-close refuses). Spec gains the two scenarios; CHANGELOG 3.3.0 records it. Refs #366
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Before diagnosing or implementing, IDD now asks whether an open PR or an existing branch already addresses the issue (#366).
scripts/check-existing-work.shanswers this for every issue in one call. It fetches the PR lists once, runsgit fetch, and reads the remote-tracking refs for branches. It returns a verdict per issue:blocked,resume,unknownorclear.idd-all,idd-all-chain,idd-diagnose,idd-implementandidd-closeconsult it.references/pr-issue-matching.mddocuments the matching rules.check-existing-work. Spectra change:add-existing-work-lookup(13/13 tasks).[Unreleased]CHANGELOG section becomes 3.3.0, and the README version table gets a 3.3.0 row.Fixed before merge (security review)
verdict=). They now fall back to{}, which givesunknown.idd-closeStep 1.5 passed whengh issue viewfailed, even with an open PR declaring the issue. It now refuses in that case.b6c5104.Notes
main, and is committed here./idd-verifyrun, by maintainer decision.spectra validate add-existing-work-lookuppasses.Refs #366