Repository navigation
asort()/arsort(): zend_sort + zend_compare - #37727
Merged
Merged
Conversation
Bubble sort (n² pass cap) comparing every non-string value with readLong — floats were truncated, so 1.5 and 1.2 compared equal. Now ZendSortLlvm over the exported [key, value] pairs with php_array_data_compare semantics (ZendCompareLlvm; SORT_FLAG_CASE keeps strcasecmp on string pairs), negated for arsort, stable tiebreak. Output for keyed arrays is still limited by the pre-existing pair write-back (int keys stringified, mixed key kinds) — the hashtable has no ordered representation across key kinds; tracked separately. Gates: AOT differential sweep failing set identical to master (379 ok / 8 fail). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bubble sort → exact zend_sort with zend_compare (floats no longer truncated). Gate: AOT differential sweep failing set identical to master.
🤖 Generated with Claude Code