Repository navigation
bug: accept urls in --notify-webhooks - #672
Open
Amadeus-22 wants to merge 1 commit into
Open
Amadeus-22 wants to merge 1 commit into
Amadeus-22 wants to merge 1 commit into
Conversation
The webhook configuration was split on every colon, so the scheme and port of a URL were cut off the address and the rest was read as a header, which raised IndexError for any real URL. Only the trailing NAME=VALUE parts are headers now, and a header is split on its first '=' so values containing '=' are kept whole. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #671.
lean cloud live deploy --notify-webhookssplit the value on every colon. With a real URL the scheme (and port) was cut off the address and the remainder was parsed as a header, raisingIndexError: list index out of range. A header value containing=was truncated._parse_webhook_config: only the trailingNAME=VALUEparts are headers, the rest is the address, and each header is split on its first=. Values that worked before parse the same way.test_cloud_live_deploy_with_notificationsgets three URL cases (no headers, port plus query string, header value with=). They fail on master and pass with the fix; the expected values are now written out instead of being re-parsed with the same logic as the command.pytest tests/commands/cloud/live/test_cloud_live_commands.pypasses (68 tests, Python 3.12) andpython static_analysis.pyis clean.🤖 Generated with Claude Code