Repository navigation
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests.
... and 4 files with indirect coverage changes 🚀 New features to boost your workflow:
|
lkdvos
reviewed
Nov 3, 2026
lkdvos
reviewed
Nov 3, 2026
lkdvos
left a comment
lkdvos
left a comment
Member
There was a problem hiding this comment.
Does it make sense to also do this for the CPU versions? I think in general we kind of held off on that until it showed up in some profiler, but if we already have the machinery, might as well?
Member
Author
|
Yeah I think so, should that be part of this PR or separate, do you think? |
lkdvos
reviewed
Nov 3, 2026
lkdvos
left a comment
lkdvos
left a comment
Member
There was a problem hiding this comment.
Yeah, fair enough, probably better in a separate PR
lkdvos
approved these changes
Nov 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Revealed to be needed by QuantumKitHub/PEPSKit.jl#482
Adds some diagonal specializations for the GPU
add_transformlogic and some tests, happily we can reuse a lot of stuff. Adds more caches, sorry :(.