Skip to content

fix: bump Dependabot-flagged rpassword, serde_with, ws, and bn.js - #717

Open
illuzen wants to merge 1 commit into
mainfrom
deps/chain-security-bumps
Open

illuzen wants to merge 1 commit into
mainfrom
deps/chain-security-bumps

Conversation

@illuzen

@illuzen illuzen commented Oct 26, 2026

Copy link
Copy Markdown
Contributor

Summary

Test plan

  • cargo check --locked -p sc-network-types -p sc-cli -p quantus-node
  • ./clippy.sh (taplo is not installed locally, so that step was skipped; clippy passed)
  • Confirm Dependabot clears the six JS alerts and the rpassword and serde_with alerts after merge

Made with Cursor

These releases cover the alerts whose patched versions fit the existing dependency ranges.

Co-authored-by: Cursor <cursoragent@cursor.com>

@n13 n13 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict: Approve
Reviewer: GPT-6.1 Sol

Reviewed head 2c4918ba22cb08f6439fdf62da68d227420f82d8 against base 9e6d01f8bbefd126d87be6325e8cfc1f09825ae9 in an isolated detached worktree.

No blocking findings. The Rust minimum-version constraints exclude the affected advisory ranges, and all four locked updates cover the eight Dependabot alerts listed in the PR. The updated Rust dependencies support the pinned Rust 1.93 toolchain. Both JavaScript lockfiles agree on versions, URLs, and integrity hashes; the affected callers and dependency ranges remain compatible.

Validation:

  • git diff --check, Taplo on Cargo.toml, and cargo metadata --locked --offline: passed.
  • cargo test --locked --offline -p sc-network-types: 9 unit tests and 1 doctest passed.
  • Additional temporary checks passed for peer-ID/address Serde traits and deserialization, including malformed-input rejection.
  • cargo check --locked --offline -p rpassword: passed.
  • SKIP_WASM_BUILD=1 cargo check --locked --offline -p sc-cli -p quantus-node: passed (Wasm build skipped).
  • npm ci --ignore-scripts --no-audit --no-fund and Yarn 1.22.22 install --frozen-lockfile --ignore-scripts --non-interactive: passed without tracked-file changes.
  • JavaScript smoke checks passed for the bn.js zero-bit mask regression and arithmetic, Polkadot signing/verification, a local WsProvider JSON-RPC roundtrip, and WebSocket close-reason validation.

CI: formatting and Clippy/documentation passed; the Linux and macOS build/test jobs are still in progress. Both dependency-cooldown runs failed because ws@8.22.0 was 29 days old at check time, below the required 30 days. Before merging, rerun after the full cooldown elapses or use the established emergency-bypass process. Full CI has not yet passed.

@n13 n13 removed the bot-review label Oct 26, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants