Repository navigation
Conversation
These releases cover the alerts whose patched versions fit the existing dependency ranges. Co-authored-by: Cursor <cursoragent@cursor.com>
n13
left a comment
There was a problem hiding this comment.
Verdict: Approve
Reviewer: GPT-6.1 Sol
Reviewed head 2c4918ba22cb08f6439fdf62da68d227420f82d8 against base 9e6d01f8bbefd126d87be6325e8cfc1f09825ae9 in an isolated detached worktree.
No blocking findings. The Rust minimum-version constraints exclude the affected advisory ranges, and all four locked updates cover the eight Dependabot alerts listed in the PR. The updated Rust dependencies support the pinned Rust 1.93 toolchain. Both JavaScript lockfiles agree on versions, URLs, and integrity hashes; the affected callers and dependency ranges remain compatible.
Validation:
git diff --check, Taplo onCargo.toml, andcargo metadata --locked --offline: passed.cargo test --locked --offline -p sc-network-types: 9 unit tests and 1 doctest passed.- Additional temporary checks passed for peer-ID/address Serde traits and deserialization, including malformed-input rejection.
cargo check --locked --offline -p rpassword: passed.SKIP_WASM_BUILD=1 cargo check --locked --offline -p sc-cli -p quantus-node: passed (Wasm build skipped).npm ci --ignore-scripts --no-audit --no-fundand Yarn 1.22.22install --frozen-lockfile --ignore-scripts --non-interactive: passed without tracked-file changes.- JavaScript smoke checks passed for the
bn.jszero-bit mask regression and arithmetic, Polkadot signing/verification, a localWsProviderJSON-RPC roundtrip, and WebSocket close-reason validation.
CI: formatting and Clippy/documentation passed; the Linux and macOS build/test jobs are still in progress. Both dependency-cooldown runs failed because ws@8.22.0 was 29 days old at check time, below the required 30 days. Before merging, rerun after the full cooldown elapses or use the established emergency-bypass process. Full CI has not yet passed.
Summary
rpasswordto 7.5.4 (alert Integrate scheduler to reversible transfers #53) andserde_withto 3.22.0 (alert Docker install update 3 #62).wsto 8.22.0 andbn.jsto 5.2.5 inscripts/js, in bothpackage-lock.jsonandyarn.lock(alerts docker push latest tag #60, Revert "make container package public (#58)" #59, make container package public #58, add binary docker file build #57, feat: vest airdrop rewards #22, and Feature/installer script #21).lrustays at 0.7.8 and 0.12.5. The fix is in 0.16.3, andtracing-log0.2 plussmoldot-light0.17 do not allow that major. Alert Rename quantus #14 needs a dismiss, not a version bump.Test plan
cargo check --locked -p sc-network-types -p sc-cli -p quantus-node./clippy.sh(taplois not installed locally, so that step was skipped; clippy passed)rpasswordandserde_withalerts after mergeMade with Cursor