Skip to content

feat: add recent 24 active account - #63

Merged
dewabisma merged 1 commit into
mainfrom
beast/add-recent-24-active-account
Oct 21, 2026
Merged

dewabisma merged 1 commit into
mainfrom
beast/add-recent-24-active-account

Conversation

@dewabisma

Copy link
Copy Markdown
Collaborator

No description provided.

@dewabisma
dewabisma requested a review from n13 October 21, 2026 13:50

@n13 n13 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewer model: GPT-6.1 Sol

APPROVE — no blocking findings at 35449723251d90b6052c079a0179b882cec44fb7 (base 83f9be56a76114a57bf94f1954ed01bac8748930).

Reviewed the complete six-file diff and the surrounding query, date-range, hook, and card code. The aggregate counts distinct non-null extrinsic signers within the supplied time bounds, and the count reaches the subtitle through the existing loading/error handling.

Validation:

  • bun run build passed (Vite and TypeScript).
  • All 19 focused tests passed across the new active-account filter, transaction filters, and homepage stats utilities.
  • git diff --check and Prettier checks on all changed files passed.
  • The exact homepage query succeeded against both configured public GraphQL endpoints (mainnet and Planck).
  • Full bun test: 195 passed, 3 failed. The same three failures reproduce on the base commit (194 passed, 3 failed): two AccountAddressCell tests and one BlockInformation test. These are pre-existing failures.
  • All current GitHub checks are successful.

@dewabisma
dewabisma merged commit 8646dd4 into main Oct 21, 2026
3 checks passed
@dewabisma
dewabisma deleted the beast/add-recent-24-active-account branch October 21, 2026 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants