Repository navigation
Conversation
📌 Code Review Assignment🏷️ Tag: componentsReviewers: @Maihuanyi Changed Files (Click to expand)
📊 Current Review Status (Last Updated: 2026-10-13 16:09 CST)
📝 Review Instructions
|
|
👋 感谢您对 RT-Thread 的贡献!Thank you for your contribution to RT-Thread! 为确保代码符合 RT-Thread 的编码规范,请在你的仓库中执行以下步骤运行代码格式化工作流(如果格式化CI运行失败)。 🛠 操作步骤 | Steps
完成后,提交将自动更新至 如有问题欢迎联系我们,再次感谢您的贡献!💐 |
4d37cd8 to
72d39c3
Compare
There was a problem hiding this comment.
🟡 Changes recommended
Pbuf margin handling and AP reconfiguration remain incomplete, and the PR metadata does not describe the full scope.
6 open findings
pbuf_realloc drops reserved tailroom when shrinking · New AP configuration comparison omits the band · New Advanced AP API fails to restart for active configuration changes · New Shared margin option is unsupported in three lwIP versions · New PR title omits WLAN management changes · New PR description is still missing required change and validation details · New
What changed in this PR
Adds lwIP tuning controls alongside WLAN and DHCP reliability changes. / 增加 lwIP 调优配置,并改进 WLAN 与 DHCP 可靠性。
Changes:
- Adds configurable lwIP memory, pbuf, and mailbox settings.
- Improves DHCP cleanup and WLAN state/error handling.
- Adds direct WLAN-to-lwIP packet input.
| File | Description |
|---|---|
components/net/lwip/port/lwipopts.h |
Adds lwIP configuration overrides. |
components/net/lwip/lwip-2.1.2/src/core/pbuf.c |
Adds configurable pbuf tailroom. |
components/net/lwip-dhcpd/dhcp_server_raw.c |
Improves lease traversal and startup cleanup. |
components/drivers/wlan/dev_wlan_prot.h |
Declares direct lwIP input API. |
components/drivers/wlan/dev_wlan_mgnt.c |
Updates disconnect and AP reconfiguration handling. |
components/drivers/wlan/dev_wlan_lwip.c |
Clears DNS, adds direct input, and propagates TX errors. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.



拉取/合并请求描述:(PR description)
[
为什么提交这份PR (why to submit this PR)
你的解决方案是什么 (what is your solution)
请提供验证的bsp和config (provide the config and bsp)
]
当前拉取/合并请求的状态 Intent for your PR
必须选择一项 Choose one (Mandatory):
代码质量 Code Quality:
我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:
#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up