Repository navigation
Treat Qodana findings as errors, and fix the one it reports - #20
Merged
Merged
Conversation
A full scan of main (dispatched run 36986040675; the CLI ran with no diff range) reports one problem in the whole hand-written codebase: IGlobalSession.pinDownstreamCompilersToPayload called equals on DownstreamPath.SEGMENT, which the data-flow analysis cannot prove non-null (it held MemorySegment.NULL as a "no payload" sentinel via Optional.orElse). The field now holds null for that case and the method null-checks it, which says the same thing without the sentinel. qodana.yaml gains a quality gate (failureConditions.severityThresholds.any: 0), so any finding fails the Qodana job instead of leaving a neutral check. PR and push runs analyse only changed files, so this gates new findings; a dispatched run still covers everything. Tested: :slang:test 43/43 against the 2026.19 macos-aarch64 payload, which takes the payload-directory path through the changed method. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Qodana for JVMIt seems all right 👌 No new problems were found according to the checks applied 💡 Qodana analysis was run in the pull request mode: only the changed files were checked View the detailed Qodana reportTo be able to view the detailed Qodana report, you can either:
To get - name: 'Qodana Scan'
uses: JetBrains/qodana-action@v2026.1.3
with:
upload-result: trueContact Qodana teamContact us at qodana-support@jetbrains.com
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes Qodana findings fail the build, and fixes the only one it reports.
IGlobalSession.pinDownstreamCompilersToPayloadcalledequalson a field that held aMemorySegment.NULLsentinel, which Qodana's data-flow analysis flagged as a possible NPE. The field now holdsnullfor "no payload directory" and the method null-checks it.qodana.yamladdsfailureConditions.severityThresholds.any: 0, so any finding fails the Qodana job instead of leaving a neutral check. PR and push runs only analyse changed files, so this gates new findings; a dispatched run covers everything.A full scan of
main(run 36986040675) found this one problem and nothing else.:slang:test43/43 locally against the 2026.19 macos-aarch64 payload. This PR's Qodana run is the first with the gate on.🤖 Generated with Claude Code