Skip to content

Build fix - #298

Merged
ucswift merged 1 commit into
masterfrom
develop
Oct 26, 2026
Merged

ucswift merged 1 commit into
masterfrom
develop

Conversation

@ucswift

@ucswift ucswift commented Oct 26, 2026 •

Copy link
Copy Markdown
Member

Pull Request Summary

Fixes multi-architecture Docker builds in the React Native CI workflow.

Changes

  • Adds the Docker QEMU setup action so ARM64 runtime stages can execute correctly on the host through registered emulation handlers.
  • Forces the Docker build stage to run on the native builder platform instead of emulating it under ARM64.
  • Keeps the static asset build compatible with cross-platform builds while avoiding slow or failing yarn install operations under QEMU.

This improves the reliability and performance of ARM64 Docker image builds.

Summary by CodeRabbit

  • Build Improvements
    • Improved support for producing ARM64-compatible builds.

@Resgrid-Bot

Resgrid-Bot commented Oct 26, 2026 •

Copy link
Copy Markdown

Kody Review Complete

Great news! 🎉
No issues were found that match your current review configurations.

Keep up the excellent work! 🚀

Kody Guide: Usage and Configuration
Interacting with Kody
  • Request a Review: Ask Kody to review your PR manually by adding a comment with the @kody start-review command at the root of your PR.

  • Validate Business Logic: Ask Kody to validate your code against business rules by adding a comment with the @kody -v business-logic command.

  • Provide Feedback: Help Kody learn and improve by reacting to its comments with a 👍 for helpful suggestions or a 👎 if improvements are needed.

Current Kody Configuration
Review Options

The following review options are enabled or disabled:

Options Enabled
Bug ✅
Performance ❌
Security ✅
Business Logic ❌

Access your configuration settings here.

​

@coderabbitai

coderabbitai Bot commented Oct 26, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Essentials
  • Run ID: ad60e43c-c8ec-46cc-82d2-095d48de3371
Commits

Reviewing files that changed from the base of the PR and between 01eb09a and 1827538.

Files selected for processing: 2
  • .github/workflows/react-native-cicd.yml
  • Dockerfile

Included review availability: This review used your included allowance. 3 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 4 reviews per hour.

Walkthrough

The Docker build stage now uses $BUILDPLATFORM. The build-docker workflow job sets up QEMU before Docker Buildx.

Changes: Platform-aware Docker build

Layer / File(s) Summary
Platform-aware build setup
Dockerfile, .github/workflows/react-native-cicd.yml
The build stage uses $BUILDPLATFORM. The workflow registers QEMU binfmt handlers before configuring Docker Buildx. This supports running the arm64 runtime stage under the host’s QEMU.

Priority: Low

Estimated code review effort: 2 (Simple) | ~8 minutes

Change: Bug fix

Merge Risk: Minimal · up to 18275

The platform-aware Docker changes are mergeable with no identified build or runtime risk.

Pre-merge checks: Passed 4 · Inconclusive 1

Failed Failed checks: 1 inconclusive

Check name Status Explanation Resolution
Title check Inconclusive The title, "Build fix," relates to the changes but is too vague to identify the Docker and QEMU build changes. Use a specific title such as "Fix cross-platform Docker builds with QEMU and BUILDPLATFORM".
Passed Passed checks: 4 passed
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (2 skipped: 2 unsupported.)

Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@ucswift
ucswift merged commit 46f6d6a into master Oct 26, 2026
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants