Repository navigation
Add CI tests - #44
Open
Flamefire wants to merge 12 commits into
Open
Add CI tests#44Flamefire wants to merge 12 commits into
Flamefire wants to merge 12 commits into
Conversation
Flamefire
force-pushed
the
ci-fix
branch
5 times, most recently
from
October 22, 2026 12:26
f691e91 to
4f85b7a
Compare
The template dependended on the class template first and short-circuit logic made it then fail hard instead of SFINAE on invocation.
Flamefire
force-pushed
the
ci-fix
branch
10 times, most recently
from
October 25, 2026 14:42
d3d51e9 to
8eea9e5
Compare
Output each failed filename and use exit code for each. The previous version printed to stderr so never triggered the failure check.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add CI to this repo to detect regressions early here instead of when updating the submodule.
Motivation is the CI failure on some MSVC version reported here, the fix is included here.
This also moves some scripts from libsiedler2 repo here as that depends on this one anyway so we can keep them in a single location.
@Flow86 Does it still make sense to have the libendian submodule? This repo already has 3 mostly independent libraries/targets and additional submodules increase the maintenance effort.
Especially getting the clones and layout right for libutil and libsiedler2 CI was a bit tricky. One repo less would help.
I'd hence move the contents of the libendian repo to the
libsfolder here and merge the CMake configs and tests