fix: recognise Rocky/Alma/CentOS Stream lsb_release IDs in is_redhat - #1664
Open
stantheman0128 wants to merge 2 commits into
Open
stantheman0128 wants to merge 2 commits into
stantheman0128 wants to merge 2 commits into
Conversation
lsb_release -s -i on current RHEL rebuilds reports IDs missing from @redhat_clones, so pkg lookups died once redhat-lsb-core was installed. Match the OS name exactly so substrings like Red no longer false-match. Fixes RexOps#1661
stantheman0128
force-pushed
the
is-redhat-lsb-ids
branch
from
October 1, 2026 11:54
997f6e7 to
4ea4621
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request proposes to fix #1661 by adding current RHEL-rebuild lsb_release IDs to
@redhat_clonesand comparing OS names exactly (case-insensitive) instead of as an unanchored regex.Please review, then either merge, or let me know how to improve it further.
prepared with Cursor
Checklist towards merging
Verification
Reproduced the list gap on this Mac by calling
is_redhatwith an explicit OS argument (no Rocky host required):After the fix:
Rocky,AlmaLinux, and friends return true;RedandDebianreturn false.Made with Cursor