[Web runtime] Add WebSocket and HTTP/SSE action demos by minggangw · Pull Request #1614 · RobotWebTools/rclnodejs

minggangw · 2026-09-20T07:11:44Z

Add Fibonacci action demos with feedback, results, WS cancellation and HTTP stream detachment.
Handle transport switching, page cleanup and restoration without stale updates.
Improve responsive layouts, configurable ports and demo setup instructions.
Clarify ROS-role/transport support, action lifecycle and SDK limitations in public docs.

Copilot

Copilot review overview

🟡 Changes recommended

The documented walkthrough references a missing http-action-client-example.mjs file, so the advertised client step cannot run.

Get a fresh assessment by requesting another Copilot review.

Review effort: Lite
Findings: 1

Open (1)

Referenced HTTP action client example file is missing · New

What changed in this PR

Adds HTTP/SSE action documentation and Fibonacci browser demos for JavaScript and TypeScript.

Changes:

Documents action APIs, SSE, cancellation, and OpenAPI support.
Adds Fibonacci action servers and browser controls.
Updates demo configuration, styling, and README guidance.

File	Summary
`web/README.md`	Documents browser actions and HTTP/SSE usage
`scripts/npmjs-readme.md`	Updates package README action guidance
`README.md`	Updates the web SDK overview
`example/actions/README.md`	Adds an HTTP/SSE action walkthrough
`demo/web/typescript/web.json`	Exposes the Fibonacci action and CORS
`demo/web/typescript/src/style.css`	Adds responsive action styling
`demo/web/typescript/src/main.ts`	Implements typed action controls
`demo/web/typescript/server.ts`	Adds the TypeScript Fibonacci action server
`demo/web/typescript/README.md`	Documents the TypeScript action demo
`demo/web/typescript/index.html`	Adds the Fibonacci action panel
`demo/web/javascript/web.json`	Exposes the Fibonacci action
`demo/web/javascript/runtime.mjs`	Adds the JavaScript Fibonacci action server
`demo/web/javascript/README.md`	Documents the JavaScript action demo
`demo/web/javascript/index.html`	Adds the JavaScript action panel and controls

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

coveralls · 2026-09-20T07:19:45Z

coverage: 91.155%. remained the same — minggangw:add-sse-action-example into RobotWebTools:develop

Copilot

Copilot review overview

🟡 Changes recommended

The walkthrough references a missing client file, and both browser demos remain disconnected after a back-forward-cache restore.

Get a fresh assessment by requesting another Copilot review.

Review effort: Balanced
Findings: 3

Open (3)

Reconnect SDK and EventSource after bfcache restoration · New
Reconnect after back-forward cache restoration · New
Referenced HTTP action client example file is missing

Copilot

Copilot review overview

🟡 Changes recommended

The TypeScript demo passes null to a parameter that only accepts a callback or undefined, causing strict type-checking to fail.

Get a fresh assessment by requesting another Copilot review.

Review effort: Balanced
Findings: 1 · 3

Open (4)

Pass undefined instead of null for accepted-goal handler · New
Reconnect after back-forward cache restoration
Reconnect SDK and EventSource after bfcache restoration
Referenced HTTP action client example file is missing

Copilot

Copilot review overview

🔵 Needs a closer look

Cross-transport action cancellation, streaming, and browser lifecycle behavior warrant final human validation.

Review effort: Balanced
Findings: 1

Open (1)

Referenced HTTP action client example file is missing

Resolved since last review (3)

Pass undefined instead of null for accepted-goal handler
Reconnect after back-forward cache restoration
Reconnect SDK and EventSource after bfcache restoration

Copilot

🔵 Needs a closer look

Subscription lifecycle races remain unresolved, and cached-page restoration and native action shutdown need human integration validation.

1 open finding

Subscription controls remain stuck during transport switch race · New

1 resolved since last review

Referenced HTTP action client example file is missing

🧠 Review effort: Balanced

Give feedback about Copilot approvals in this survey to enter a drawing for a $150 gift card.

+        chatterSub = null;
+        ros = null;
+        updateActionControls();
+        await detachAction();


Copilot AI lite review requested due to automatic review settings September 20, 2026 07:11

Copilot started reviewing on behalf of minggangw September 20, 2026 07:12 View session

Copilot AI reviewed Sep 20, 2026

View reviewed changes

Comment thread example/actions/README.md Outdated

minggangw requested a balanced review from Copilot September 20, 2026 07:39

Copilot started reviewing on behalf of minggangw September 20, 2026 07:40 View session

Copilot AI reviewed Sep 20, 2026

View reviewed changes

Comment thread demo/web/javascript/index.html Outdated

Comment thread demo/web/typescript/src/main.ts

minggangw requested a balanced review from Copilot September 20, 2026 07:51

Copilot started reviewing on behalf of minggangw September 20, 2026 07:52 View session

Copilot AI reviewed Sep 20, 2026

View reviewed changes

Comment thread demo/web/typescript/server.ts Outdated

minggangw requested a balanced review from Copilot September 21, 2026 05:21

Copilot started reviewing on behalf of minggangw September 21, 2026 05:21 View session

Copilot AI reviewed Sep 21, 2026

View reviewed changes

minggangw requested a balanced review from Copilot October 8, 2026 06:17

Copilot started reviewing on behalf of minggangw October 8, 2026 06:18 View session

Copilot AI reviewed Oct 8, 2026

View reviewed changes

Comment thread demo/web/javascript/index.html

chatterSub = null;

ros = null;

updateActionControls();

await detachAction();

minggangw added 10 commits October 9, 2026 09:31

Add HTTP/SSE action examples and browser demos

2e1c1e9

Addrss comments

2afe0e9

Addrss comments

1fee6ec

Addrss comments

30c6e7b

Remove action example

6c64817

Revise README

58b1131

Update web/README.md

70d7c3a

Remove private doc

56fb425

Update doc

5fe40a5

Update doc

ea83316

minggangw force-pushed the add-sse-action-example branch from d5bce2c to ea83316 Compare October 9, 2026 01:46

minggangw changed the title ~~Add HTTP/SSE action examples and browser demos~~ [Web runtime] Add WebSocket and HTTP/SSE action demos Oct 9, 2026

minggangw merged commit c7e70cd into RobotWebTools:develop Oct 9, 2026
17 checks passed

Navigation Menu

Repository navigation

[Web runtime] Add WebSocket and HTTP/SSE action demos - #1614

[Web runtime] Add WebSocket and HTTP/SSE action demos#1614
minggangw merged 10 commits into
RobotWebTools:developfrom
minggangw:add-sse-action-example

minggangw commented Sep 20, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

coveralls commented Sep 20, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

minggangw commented Sep 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🟡 Changes recommended

Uh oh!

Uh oh!

coveralls commented Sep 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🟡 Changes recommended

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🟡 Changes recommended

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🔵 Needs a closer look

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🔵 Needs a closer look

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

minggangw commented Sep 20, 2026 •

edited

Loading

coveralls commented Sep 20, 2026 •

edited

Loading