Skip to content

fix(react): validate filename and handle errors in AttachmentPreview submit #1414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yashsarvaiya45 wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

fix(react): validate filename and handle errors in AttachmentPreview submit #1414

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions packages/react/src/views/AttachmentPreview/AttachmentPreview.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,18 +70,21 @@ const AttachmentPreview = () => {

const submit = async () => {
if (isPending) return;
if (!fileName || !fileName.trim()) return;
if (msgMaxLength && description.length > msgMaxLength) return;

setIsPending(true);
try {
await RCInstance.sendAttachment(
data,
fileName,
fileName.trim(),
parseEmoji(description),
ECOptions?.enableThreads ? threadId : undefined
);
toggle();
setData(null);
} catch (error) {
console.error('Error uploading attachment:', error);
} finally {
setIsPending(false);
}
Expand Down Expand Up @@ -250,7 +253,10 @@ const AttachmentPreview = () => {
Cancel
</Button>

<Button disabled={isPending || isOverLimit} onClick={submit}>
<Button
disabled={isPending || isOverLimit || !fileName?.trim()}
onClick={submit}
>
{isPending ? 'Sending...' : 'Send'}
</Button>
</Modal.Footer>
Expand Down