Repository navigation
fix: refresh room information when room settings change - #1415
Open
ankitjha1405 wants to merge 1 commit into
Open
ankitjha1405 wants to merge 1 commit into
ankitjha1405 wants to merge 1 commit into
Conversation
|
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: refresh room information when room settings change
Acceptance Criteria fulfillment
Fixes #1119
What changed
ChatHeadernow listens for incoming room-change system messages (r,room_changed_topic,room_changed_announcement,room_changed_description,room_changed_privacy). When one arrives, it callsrooms.infoagain and writes the result tochannelStore. The header and Room Information both readchannelInfofrom that store, so both re-render with the new values.isChannelPrivateis also set from the fresh room, so a private-to-public change works too, not only public-to-private.The listener uses the existing
addMessageListener/removeMessageListenerAPI and is removed on unmount and logout. Only live stream messages reach these listeners, so loading message history does not trigger extra requests.One file, 23 lines added.
Video/Screenshots
Not recorded yet. I will add a recording from the PR preview build.
PR Test Details
prettier --check(2.8.8) passes on the changed file..eslintrc.json: no new errors or warnings. The tworeact-hooks/exhaustive-depswarnings in this file were already there before the change.AI assistance: I used Claude (Anthropic) to find this issue, trace the code and write the change. I have read and understand every line.
Note: The PR will be ready for live testing at https://rocketchat.github.io/EmbeddedChat/pulls/pr-1415 after approval. Contributors are requested to replace
<pr_number>with the actual PR number.