[kra]

… the implentation is example code with a hardcoded key which will be an error if used.

Summary by CodeRabbit

• Refactor
  • Removed the with_children() method for taxon queries.

[netlify]

✅ Deploy Preview for antenna-ssec canceled.

Name	Link
🔨 Latest commit	add6f75
🔍 Latest deploy log	https://app.netlify.com/projects/antenna-ssec/deploys/6ad6ac797994dfa29df49367

[netlify]

✅ Deploy Preview for antenna-preview canceled.

Name	Link
🔨 Latest commit	add6f75
🔍 Latest deploy log	https://app.netlify.com/projects/antenna-preview/deploys/6ad6ac7942d6314712ef97f3

[coderabbitai]

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration

• Configuration used: defaults
• Review profile: CHILL
• Plan: Advanced
• Run ID: 4e633623-6813-4f72-afe7-105ac9c4baa5

📥 Commits

Reviewing files that changed from the base of the PR and between 17bce99 and add6f75.

📒 Files selected for processing: 1

• ami/main/models_future/taxonomy.py

+-------------------------------------------------------------------------------+
| Fancy algorithms are slow when n is small, and n is usually small. - Rob Pike |
+-------------------------------------------------------------------------------+
  \
   \   (\__/)
       (•ㅅ•)
       / 　 づ

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

• Configuration used: defaults
• Review profile: CHILL
• Plan: Advanced
• Run ID: 1d14b256-9cb1-4491-a9d7-f5ac8211da78

📥 Commits

Reviewing files that changed from the base of the PR and between e4819a3 and 17bce99.

📒 Files selected for processing (1)

• ami/main/models_future/taxonomy.py

💤 Files with no reviewable changes (1)

• ami/main/models_future/taxonomy.py

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

📝 Walkthrough

The change removes TaxonManager.with_children(), which queried parents_json for child taxon IDs and used the query to annotate a queryset.

Changes: Taxonomy manager

Layer / File(s)	Summary
Remove child annotation method ami/main/models_future/taxonomy.py	TaxonManager.with_children() is removed. It queried parents_json for child taxon IDs and used the query to annotate a queryset.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Refactor

Merge Risk: ⚪ Minimal · up to 17bce

This change removes an unused helper method from the taxonomy manager. No behavior change or production impact is expected, and no merge-blocking concerns were found.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Description check		The description gives the reason for the removal but omits most required sections, including the summary, detailed description, testing information, deployment notes, and checklist.	Complete the required pull request template. Add the summary, list of changes, related issues or state that none apply, detailed description with risks, testing steps and results, screenshots or an applicable statement, deployment notes, an…

✅ Passed checks (4 passed)

Check name	Status	Explanation
Docstring Coverage		No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.
Title check		The title clearly identifies the removal of TaxonManager.with_children(), which matches the main change.

Full details: Description check

Resolution

Complete the required pull request template. Add the summary, list of changes, related issues or state that none apply, detailed description with risks, testing steps and results, screenshots or an applicable statement, deployment notes, and checklist status.

• Fix all pre-merge checks with AI

✨ Finishing Touches

📝 Generate docstrings

• Commit to this branch
• Create a new PR

🧪 Generate unit tests (beta)

• Commit to this branch
• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[mihow]

Funny I think this was a note to myself, because we do need to query all children for some missing features, and I will not remember how to do this:

        taxa = Taxon.objects.filter(parents_json__contains=[{"id": taxon.id}])
        qs = qs.annotate(children=models.Subquery(taxa.values("id")))

Maybe that can go in a docstring somewhere else.

[kra]

add it to the issue that adds the missing features?