Repository navigation
Conversation
✅ Deploy Preview for antenna-preview canceled.
|
Contributor
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 55 minutes. View limit details
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to
|
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Docstring Coverage |  |
Docstring coverage is 32.73% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 165 functions across 5 files. | Write docstrings for the functions missing them to satisfy the coverage threshold. |
-
Check name Status Explanation Title check The title clearly identifies the TaxonManager.update_display_names()issue addressed by the pull request and is specific to the main fix.Description check The description includes a summary, changed files, detailed rationale, and test instructions. It omits the template checklist and deployment or issue notes, but the core information is complete. Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches: 💡 2
-
📝 Generate docstrings: 💡
-
- Commit to this branch
- Create a new PR
⚔️ Resolve merge conflicts: 💡
-
- Resolve merge conflict in branch
kra/model-split-tests-storage-taxonomy-updatedisplaynames
- Resolve merge conflict in branch
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
- _case_from_map - verified_taxon_counts - TaxonRank - TaxonQuerySet - TaxonManager - TaxonParent - Taxon - TaxaListQuerySet - TaxaListManager - TaxaList - Tag Because main.models still has to re-export from models_future until migrations and other code stops referencing it: - Added imports in some methods, since module-level imports must be avoided to avoid circular imports. - Changed type hinting for some methods to strings (to be evauluated by the linter without a change in behavior) to avoid circular imports. Added unit tests for models_future.taxonomy. Some of these were driven by coverage needs. I didn't remove tests from ami.main, which means we have duplicate coverage. The tests were all blatted out by AI and I didn't work hard to understand them. There should be no functionality changes, including possible bugfixes.
kra
force-pushed
the
kra/model-split-tests-storage-taxonomy
branch
from
October 9, 2026 22:18
e4819a3 to
87c836c
Compare
…, it gets and uses the default queryset. An empty queryset is falsy, so selecting that will cause the default queryset to be used. Fixed this by removing the None default (which the admin action, the only caller, doesn't use anyway), so the given queryset must be used.
kra
force-pushed
the
kra/model-split-tests-storage-taxonomy-updatedisplaynames
branch
from
October 9, 2026 23:07
63acf04 to
e9723af
Compare
- _case_from_map - verified_taxon_counts - TaxonRank - TaxonQuerySet - TaxonManager - TaxonParent - Taxon - TaxaListQuerySet - TaxaListManager - TaxaList - Tag Because main.models still has to re-export from models_future until migrations and other code stops referencing it: - Added imports in some methods, since module-level imports must be avoided to avoid circular imports. - Changed type hinting for some methods to strings (to be evauluated by the linter without a change in behavior) to avoid circular imports. Added unit tests for models_future.taxonomy. Some of these were driven by coverage needs. I didn't remove tests from ami.main, which means we have duplicate coverage. The tests were all blatted out by AI and I didn't work hard to understand them. There should be no functionality changes, including possible bugfixes.
kra
force-pushed
the
kra/model-split-tests-storage-taxonomy
branch
from
October 13, 2026 20:34
0c23191 to
6c6dd45
Compare
…en removed in the move
…split-tests-storage-taxonomy-updatedisplaynames
kra
force-pushed
the
kra/model-split-tests-storage-taxonomy
branch
from
October 19, 2026 21:18
4cc24a3 to
36db85e
Compare
Base automatically changed from
kra/model-split-tests-storage-taxonomy
to
main
October 19, 2026 22:44
✅ Deploy Preview for antenna-ssec canceled.
|
kra
marked this pull request as draft
October 21, 2026 01:07
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove unused and minorly problematic default to TaxonManager.update_display_names().
List of Changes
taxonomy.py
test_taxonomy.py
Detailed Description
If the queryset given to TaxonManager.update_display_names() is falsy, it gets and uses the default queryset. An empty queryset is falsy, so selecting that will cause the default queryset to be used. Fixed this by removing the None default (which the admin action, the only caller, doesn't use anyway), so the given queryset must be used.
How to Test the Changes
Ran through the action at http://localhost:8000/admin/main/taxon/
Ran the unit tests
Summary by CodeRabbit