Light and overlay fixes [`develop`] [4/4] by PetrilloAtWork · Pull Request #922 · SBNSoftware/icaruscode

PetrilloAtWork · 2026-08-21T19:29:58Z

This is the mirror set of pull requests as #917 and #892 (and all dependent ones).
The approval of the content of this PR is in principle the same as for those, but because this branch was obtained by cherry-picking, some additional scrutiny may be justified.

Additional PR are required before/together with this one:

Reviewers:

@jas1005 (release manager) for verifying the approval of the original pull requests
@mvicenzi (coauthor) for possible cross-checks that nothing was lost in translation

…plate It used to end when the template SPR goes under 1e-4 ADC#. Now it needs to stay within +/- 1w-4 ADC# for 20 nanoseconds. This should make it possible to include undershootings. All these parameters are currently hard-coded.

…icles that might cross cathode

Good catches on names and strings. Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

FNALbuild · 2026-10-12T21:15:49Z

❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build ICARUS phase logs

parent CI build details are available through the CI dashboard

FNALbuild · 2026-10-12T21:21:06Z

❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for e26:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build ICARUS phase logs

parent CI build details are available through the CI dashboard

FNALbuild · 2026-10-12T21:21:28Z

❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for e26:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build ICARUS phase logs

parent CI build details are available through the CI dashboard

FNALbuild · 2026-10-12T21:23:32Z

❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build ICARUS phase logs

parent CI build details are available through the CI dashboard

jas1005 · 2026-10-13T14:30:31Z

trigger build LArSoft/larsoft@v10_26_00 LArSoft/lar*@LARSOFT_SUITE_v10_26_00 SBNSoftware/sbncode@v10_26_00 SBNSoftware/sbn*@SBN_SUITE_v10_26_00 SBNSoftware/sbndaq-artdaq-core@v1_10_06_01

FNALbuild · 2026-10-13T14:49:39Z

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

FNALbuild · 2026-10-13T14:51:21Z

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

FNALbuild · 2026-10-13T14:59:50Z

❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build ICARUS phase logs

parent CI build details are available through the CI dashboard

FNALbuild · 2026-10-13T15:06:14Z

❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for e26:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build ICARUS phase logs

parent CI build details are available through the CI dashboard

jas1005 · 2026-10-13T15:49:53Z

trigger build LArSoft/larsoft@v10_26_00 LArSoft/lar*@LARSOFT_SUITE_v10_26_00 SBNSoftware/sbncode@v10_26_00 SBNSoftware/sbnalg@v10_26_00 SBNSoftware/sbndaq-artdaq-core@v1_10_06_01 SBNSoftware/sbnobj@v10_23_00 SBNSoftware/sbnanaobj@v10_26_00

FNALbuild · 2026-10-13T16:13:53Z

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

FNALbuild · 2026-10-13T16:14:41Z

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

FNALbuild · 2026-10-13T16:20:10Z

❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build ICARUS phase logs

parent CI build details are available through the CI dashboard

FNALbuild · 2026-10-13T16:21:53Z

❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for e26:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build ICARUS phase logs

parent CI build details are available through the CI dashboard

jas1005 · 2026-10-14T15:39:00Z

@PetrilloAtWork and @mvicenzi,

There are some build errors from CI build 15462 that need resolving. I'm attaching the build log from the CI build here:
buildLog_15462.txt

mvicenzi · 2026-10-14T19:07:58Z

@jas1005 This PR needs SBNSoftware/sbncode#671, which was included only in sbncode v10_27_00, not in v10_26_00. Can you try bumbing the sbncode version?

jas1005 · 2026-10-16T16:19:04Z

trigger build LArSoft/larsoft@v10_27_00 LArSoft/lar*@LARSOFT_SUITE_v10_27_00 SBNSoftware/sbncode@v10_27_00 SBNSoftware/sbnalg@v10_27_00 SBNSoftware/sbndaq-artdaq-core@v1_10_06_01 SBNSoftware/sbnobj@v10_27_00 SBNSoftware/sbnanaobj@v10_27_00

FNALbuild · 2026-10-16T16:41:27Z

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

FNALbuild · 2026-10-16T16:49:55Z

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

FNALbuild · 2026-10-16T16:50:53Z

❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build ICARUS phase logs

parent CI build details are available through the CI dashboard

FNALbuild · 2026-10-16T16:58:20Z

❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for e26:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build ICARUS phase logs

parent CI build details are available through the CI dashboard

Required separate from merge for testing via CI system.

jas1005 · 2026-10-16T21:24:04Z

trigger build LArSoft/larsoft@v10_27_00 LArSoft/lar*@LARSOFT_SUITE_v10_27_00 SBNSoftware/sbncode@v10_27_00 SBNSoftware/sbnalg@v10_27_00 SBNSoftware/sbndaq-artdaq-core@v1_10_06_01 SBNSoftware/sbnobj@v10_27_00 SBNSoftware/sbnanaobj@v10_27_00 SBNSoftware/icaruscode@v10_25_00 SBNSoftware/icarusalg#102 SBNSoftware/icarusutil@v10_24_00 SBNSoftware/icarus_signal_processing@v10_25_00

FNALbuild · 2026-10-16T21:40:40Z

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

FNALbuild · 2026-10-16T21:42:25Z

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

FNALbuild · 2026-10-16T21:49:52Z

❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build ICARUS phase logs

parent CI build details are available through the CI dashboard

FNALbuild · 2026-10-16T22:15:05Z

❌ CI build for ICARUS Failed at phase ci_tests ICARUS on slf7 for e26:prof - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the failed phase, check the ci_tests ICARUS phase logs

parent CI build details are available through the CI dashboard

jas1005 · 2026-10-16T23:15:10Z

@mvicenzi and @PetrilloAtWork,

I'm moving discussion to this ICARUSCode PR since SBNSoftware/icarusalg#102 is giving build issues. Whatever dependency mismatch issues that cause the ICARUSAlg PR not to build are not present here. Since the PRs are co-dependent, I think it's safe to just work through issues we have with this PR (see the above trigger build comment for info on how this PR was last tested with the CI system).

Building succeeds here, but there are some failing CI tests. Output from one such test (intimecosmic_reco0_quick_test_icaruscode) of build 15512 is below:

993: TrigReport ---------- Event summary -------------
994: TrigReport Events total = 1 passed = 0 failed = 1
995:
996: TrigReport ---------- Modules in End-path ----------
997: TimeReport CPU = 0.710499 Real = 0.802482
998: %MSG-s ArtException:  PostEndJob 16-Oct-2026 16:58:24 CDT ModuleEndJob
999: ---- EventProcessorFailure BEGIN
1000:   EventProcessor: an exception occurred during current event processing
1001:   ---- ScheduleExecutionFailure BEGIN
1002:     Path: ProcessingStopped.
1003:     ---- ProductNotFound BEGIN
1004:       Found zero products matching all selection criteria
1005:         C++ type: std::vector<icarus::WaveformBaseline>
1006:         Module label: 'opdaq'
1007:         Product instance name: ''
1008:         Process name: (empty)
1009:       The above exception was thrown while processing module DiscriminatePMTwaveforms/pmtfixedthr run: 1 subRun: 0 event: 88
1010:     ---- ProductNotFound END
1011:     Exception going through path path
1012:   ---- ScheduleExecutionFailure END
1013: ---- EventProcessorFailure END
1014: %MSG
1015: Art has completed and will exit with status 1.

We do not see these errors in other PRs I'm actively merging into the v10_27_00 release of ICARUSCode. So I'm inclined to think this is something with the detsim input. Can this PR use input generated by a previous code release?

mvicenzi · 2026-10-17T01:00:37Z

@jas1005 Unfortunately, this PR can't read input from older releases by default.

This is due to a breaking change in the trigger modules (e994d97), and they now require a new data product produced by the detsim stage. The behavior can be overwritten in the configuration files, but the default MCstage0 path now needs those new products.

mvicenzi and others added 30 commits August 20, 2026 14:42

fix sim label for PDFastSim

89b5994

detsim_opdetonly_icarus.fcl: simulate only optical detector digitization

aa808ae

Updated FastGaussianNoiseGeneratorAlg documentation

9b1acce

SelectCathodeCrossingGenParticles: selects generated events with part…

ad8a87e

…icles that might cross cathode

make MC2-var4 tune standard

980fa3a

simulate pmt timing delays in mc

5d226d7

disable pmt mc noise for overlays

4c90bfd

add ophituncorrected + ophit flow for mc

75a1387

update stage0 flow for overlays

90185a6

small fix

b6e85fd

prelimanary reco gain tuning

3a21af7

add SPRRun3, make SPRRun2 default

c8b658b

nullify flash calibration

835ff1b

add run3 opdet tune, make run2 default

e2b2a6a

change run3->run4, update gain

6ae6370

add run4 detsim fhicls

1c4ad07

first attempt at detsim reprocessing fhicl

4aa117e

fix typo

38358e2

Trigger simulation modules: support input tag with process name

227d4ff

Apply suggestions from GIT Copilot code review

3790b68

Good catches on names and strings. Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

fix to detsim reprocessing

39a7a59

reprocessing opdetonly overlay fhicl

b7b6d5e

leave default tags

e4ae307

add initial recalibrator module

dc24177

fix compilation for recalibrator

b136e13

link online corrections service to recalibrator

9df1310

link locally-provided old timing corrections

b76b224

fix timing recalibration

caf2544

remove custom config, fixed indentation

4d9da25

jas1005 and others added 2 commits October 16, 2026 14:32

Update dependencies

fc8a072

Required separate from merge for testing via CI system.

Merge branch 'develop' into feature/pmtsim_gainDevelop

e17d5cd

Conversation

PetrilloAtWork commented Aug 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

FNALbuild commented Oct 12, 2026

Uh oh!

FNALbuild commented Oct 12, 2026

Uh oh!

FNALbuild commented Oct 12, 2026

Uh oh!

FNALbuild commented Oct 12, 2026

Uh oh!

jas1005 commented Oct 13, 2026

Uh oh!

FNALbuild commented Oct 13, 2026

Uh oh!

FNALbuild commented Oct 13, 2026

Uh oh!

FNALbuild commented Oct 13, 2026

Uh oh!

FNALbuild commented Oct 13, 2026

Uh oh!

jas1005 commented Oct 13, 2026

Uh oh!

FNALbuild commented Oct 13, 2026

Uh oh!

FNALbuild commented Oct 13, 2026

Uh oh!

FNALbuild commented Oct 13, 2026

Uh oh!

FNALbuild commented Oct 13, 2026

Uh oh!

jas1005 commented Oct 14, 2026

Uh oh!

mvicenzi commented Oct 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jas1005 commented Oct 16, 2026

Uh oh!

FNALbuild commented Oct 16, 2026

Uh oh!

FNALbuild commented Oct 16, 2026

Uh oh!

FNALbuild commented Oct 16, 2026

Uh oh!

FNALbuild commented Oct 16, 2026

Uh oh!

jas1005 commented Oct 16, 2026

Uh oh!

FNALbuild commented Oct 16, 2026

Uh oh!

FNALbuild commented Oct 16, 2026

Uh oh!

FNALbuild commented Oct 16, 2026

Uh oh!

FNALbuild commented Oct 16, 2026

Uh oh!

jas1005 commented Oct 16, 2026

Uh oh!

mvicenzi commented Oct 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

PetrilloAtWork commented Aug 21, 2026 •

edited

Loading

mvicenzi commented Oct 14, 2026 •

edited

Loading

mvicenzi commented Oct 17, 2026 •

edited

Loading