Repository navigation
ci: modernize GitHub Actions and Node setup - #346
Merged
Merged
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
The audit gate fails on a vulnerable dependency, the release workflow may use the wrong npm version, and the pnpm upgrade leaves an incompatible workspace setting that blocks clean installs.
3 open issues
1 file not reviewed
pnpm-lock.yaml: Generated file
What changed in this PR
Modernizes CI and publishing for @smakss/react-scroll-direction while preserving the master and develop release channels.
Changes:
- Pins GitHub Actions by commit SHA and consolidates runtime setup and dependency installation through
pnpm/setup. - Selects Node 26 and pnpm 12.17.0, adding package-manager entries to the lockfile.
- Adds tests and a blocking security audit to CI, and removes registry configuration from publishing setup.
| File | Description |
|---|---|
pnpm-lock.yaml |
Adds pinned pnpm binaries and package-manager metadata. |
package.json |
Declares pnpm 12.17.0 as the package manager. |
.nvmrc |
Changes the Node version to 26. |
.github/workflows/npm-publish.yml |
Consolidates setup and removes registry configuration while retaining release channels. |
.github/workflows/ci.yml |
Pins actions, consolidates setup, runs tests, and makes audit findings fail CI. |
Review effort: Balanced
There was a problem hiding this comment.
🔵 Needs a closer look
The blocking audit fails on vulnerable dependencies in the committed lockfile, and the release workflow may use an older npm that cannot support trusted publishing.
3 open issues
1 file not reviewed
pnpm-lock.yaml: Generated file
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
.nvmrcand pnpm 12.17.0 throughpackageManager.allowBuilds: { esbuild: false }, preserving the prior install-script policy.pnpm auditfindings fail CI.Validation
pnpm audit --audit-level moderatereports no known vulnerabilities.git diff --checkpassed.cb91720passed.