Skip to content

1599 remove automatic generated file in memilio generation - #1600

Open
MaxBetzDLR wants to merge 3 commits into
mainfrom
1599-remove-automatic-generated-file-in-memilio-generation
Open

MaxBetzDLR wants to merge 3 commits into
mainfrom
1599-remove-automatic-generated-file-in-memilio-generation

Conversation

@MaxBetzDLR

@MaxBetzDLR MaxBetzDLR commented Oct 29, 2026 •

Copy link
Copy Markdown
Member

Changes and Information

Please briefly list the changes (main added features, changed items, or corrected bugs) made:

  • Removed generated file
  • Added entry to .gitignore
  • Moved config files to package subfolder, as they are not example specific anymore

If need be, add additional information and what the reviewer should look out for in particular:

Merge Request - Guideline Checklist

Please check our git workflow. Use the draft feature if the Pull Request is not yet ready to review.

Checks by code author

  • Every addressed issue is linked (use the "Closes #ISSUE" keyword below).
  • New code adheres to coding guidelines.
  • No large data files have been added (files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.).
  • Tests are added for new functionality and a local test run was successful (with and without OpenMP).
  • Appropriate documentation within the code (Doxygen) for new functionality has been added in the code.
  • Appropriate external documentation (ReadTheDocs) for new functionality has been added to the online documentation and checked in the preview.
  • Proper attention to licenses, especially no new third-party software with conflicting license has been added.
  • (For ABM development) Checked benchmark results and ran and posted a local test above from before and after development to ensure performance is monitored.

Checks by code reviewer(s)

  • Corresponding issue(s) is/are linked and addressed.
  • Code is clean of development artifacts (no deactivated or commented code lines, no debugging printouts, etc.).
  • Appropriate unit tests have been added, CI passes, code coverage and performance is acceptable (did not decrease).
  • No large data files added in the whole history of commits(files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.).
  • On merge, add 2-5 lines with the changes (main added features, changed items, or corrected bugs) to the merge-commit-message. This can be taken from the briefly-list-the-changes above (best case) or the separate commit messages (worst case).

Closes #1599

@MaxBetzDLR MaxBetzDLR self-assigned this Oct 29, 2026
@MaxBetzDLR MaxBetzDLR added the class::bug Bugs found in the software label Oct 29, 2026
@MaxBetzDLR MaxBetzDLR linked an issue Oct 29, 2026 that may be closed by this pull request
2 tasks done
@codecov

codecov Bot commented Oct 29, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.47%. Comparing base (4c83297) to head (e38323d).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1600      +/-   ##
==========================================
- Coverage   97.48%   97.47%   -0.02%     
==========================================
  Files         190      190              
  Lines       16033    16033              
==========================================
- Hits        15630    15628       -2     
- Misses        403      405       +2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@MaxBetzDLR
MaxBetzDLR requested a review from reneSchm October 29, 2026 11:42
When implementing new model features you can follow these steps:

* Add necessary configurations to `config.json.txt <https://github.com/SciCompMod/memilio/blob/main/pycode/memilio-generation/memilio/tools/config.json.txt/>`_ and add corresponding attributes to the ``ScannerConfig``.
* Add necessary configurations to `config.json.txt <https://github.com/SciCompMod/memilio/blob/main/pycode/memilio-generation/generation/tools/config.json.txt/>`_ and add corresponding attributes to the ``ScannerConfig``.

@reneSchm reneSchm Oct 30, 2026 •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?

Suggested change
* Add necessary configurations to `config.json.txt <https://github.com/SciCompMod/memilio/blob/main/pycode/memilio-generation/generation/tools/config.json.txt/>`_ and add corresponding attributes to the ``ScannerConfig``.
* Add necessary configurations to `config.json.txt <https://github.com/SciCompMod/memilio/blob/main/pycode/memilio-generation/memilio/generation/config.json.txt/>`_ and add corresponding attributes to the ``ScannerConfig``.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

class::bug Bugs found in the software

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove automatic generated file in memilio-generation

2 participants