Skip to content

Use edge-apps-actions v26.10.2 and add release badge to README - #16

Merged
salmanfarisvp merged 4 commits into
developmentfrom
chore/edge-apps-actions-v26.10.0
Oct 29, 2026
Merged

salmanfarisvp merged 4 commits into
developmentfrom
chore/edge-apps-actions-v26.10.0

Conversation

@salmanfarisvp

@salmanfarisvp salmanfarisvp commented Oct 21, 2026 •

Copy link
Copy Markdown
Member

Summary

  • Checks, Initialize and Update call the edge-apps-actions v26.10.2 reusable workflows; deploys queue instead of running side by side, and a running deploy is never cancelled.
  • Dependabot checks GitHub Actions weekly and targets development.
  • README documents the deploy method: pushes to main start a stage deploy, a v* tag on main starts the production deploy (tags not on main are refused); both wait for approval.
  • Update workflow now matches clock-app: pushes to main deploy to stage, v* tags on main deploy to production (tags not on main are refused).
  • README: release version badge and a 1920x1080 preview screenshot at the top, like clock-app.
  • README: Releasing section documenting the tag-based release (git tag + gh release create).

Releasing after merge

Merge into development first, then open a development → main PR. Pushes to main start a stage deploy (waits for approval); a v* tag on main starts the production deploy (also waits for approval).

git tag v26.10.0 && git push origin v26.10.0
gh release create v26.10.0 --verify-tag --generate-notes --title v26.10.0

salmanfarisvp and others added 2 commits October 21, 2026 20:32
Deploy stage on pushes to the default branch and production on
vYY.M.PATCH tags, refusing tags not on the default branch.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Copilot AI lite review requested due to automatic review settings October 21, 2026 15:06

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Production initialization may use non-main refs, and the README preview path is broken.

1 open issue
What changed in this PR

Updates deployment workflows to newer Edge Apps actions and adds release visibility to the README.

Changes:

  • Pins Edge Apps actions to v26.10.0 and checkout to v7.
  • Routes deployments by branch and tag.
  • Adds a release badge and preview screenshot.
File Summary
README.md Adds release badge and preview image.
.github/​workflows/​update-edge-app.yml Updates deployment triggers and action versions.
.github/​workflows/​initialize-edge-app.yml Updates initialization behavior and app ID expression.
.github/​workflows/​checks.yml Updates checks action version.

Review effort: Lite

Comment thread .github/workflows/initialize-edge-app.yml Outdated
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Copilot AI lite review requested due to automatic review settings October 21, 2026 15:14

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Preserve the production initialization checkout ref and fix the README preview image path.

1 open issue
1 previously missed issue

In code that hasn't changed since last review

Low severity Root-relative README image URL causes preview 404

README.md:5

This root-relative image URL resolves against github.com rather than this repository when the README is rendered on GitHub, so the preview will 404. Use a repository-relative path such as ./screenshots/1920x1080.webp (or a raw-content URL) so the new badge-area preview actually displays.

Review effort: Lite

Checks, Initialize and Update now call the reusable workflows; deploys
queue instead of running side by side. Dependabot checks GitHub Actions
weekly and targets development, so pin bumps go through the usual flow.
Copilot AI lite review requested due to automatic review settings October 28, 2026 13:10
@salmanfarisvp salmanfarisvp changed the title Use edge-apps-actions v26.10.0 and add release badge to README Use edge-apps-actions v26.10.2 and add release badge to README Oct 28, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The requested dependency pin is inconsistently implemented across the workflows, leaving active findings that require correction or clarification.

3 open issues
1 resolved since last review

Review effort: Lite

edge_app_title: ${{ inputs.edge_app_title }}
environment: ${{ inputs.environment }}
edge_app_id: ${{ secrets.EDGE_APP_ID || (inputs.environment == 'production' && vars.PRODUCTION_EDGE_APP_ID || (inputs.environment == 'stage' && vars.STAGE_EDGE_APP_ID)) }}
uses: Screenly/edge-apps-actions/.github/workflows/initialize.yml@v26.10.2
steps:
- uses: actions/checkout@v7
- uses: Screenly/edge-apps-actions/checks@v1
uses: Screenly/edge-apps-actions/.github/workflows/checks.yml@v26.10.2
edge_app_id: ${{ secrets.EDGE_APP_ID || vars.PRODUCTION_EDGE_APP_ID }}
jobs:
update:
uses: Screenly/edge-apps-actions/.github/workflows/update.yml@v26.10.2
@salmanfarisvp
salmanfarisvp merged commit f754a7e into development Oct 29, 2026
3 checks passed
@salmanfarisvp
salmanfarisvp deleted the chore/edge-apps-actions-v26.10.0 branch October 29, 2026 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants