Repository navigation
Release: edge-apps-actions v26.10.2 (development → main) - #19
Open
salmanfarisvp wants to merge 12 commits into
Open
salmanfarisvp wants to merge 12 commits into
salmanfarisvp wants to merge 12 commits into
Conversation
Removes the screen name from the app header (Screenly/edge-apps-library#56).
- Set STAGE_EDGE_APP_ID and PRODUCTION_EDGE_APP_ID repo variables and pass them through to the initialize/update actions as edge_app_id - Drop id from screenly.yml and delete screenly_qc.yml since a single manifest is now used regardless of environment - Pin edge-apps-actions to a commit for now, since v26.9.0 can't be tagged there until a repo ruleset is adjusted
Deploy stage on pushes to the default branch and production on vYY.M.PATCH tags, refusing tags not on the default branch. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
chore: update icon path to consolidated icons directory
Checks, Initialize and Update now call the reusable workflows; deploys queue instead of running side by side. Dependabot checks GitHub Actions weekly and targets development, so pin bumps go through the usual flow.
Use edge-apps-actions v26.10.2 and add release badge to README
main has commits that never came back to development, so a development -> main PR conflicts. Bring them in here first. Conflict in `package.json`/`bun.lock`: took `main`'s newer dependency set. `development` only bumped `@screenly/edge-apps` to ^1.2.1, and `main` already has ^26.8.0.
There was a problem hiding this comment.
🟡 Changes recommended
A critical active finding remains because production initialization can run unmerged branch code instead of being pinned to main.
1 open issue
What changed in this PR
This pull request promotes the QR Code app’s CI/CD configuration to edge-apps-actions v26.10.2 and documents the tag-based release process.
Changes:
- Replaces local checks, initialization, and deployment logic with reusable workflows.
- Removes the QC manifest, updates the primary manifest and icon path, and upgrades
@screenly/edge-apps. - Adds release documentation, a release badge, and a preview image.
- Enables weekly Dependabot updates targeting
development.
This pull request requires changes.
| File | Summary |
|---|---|
screenly.yml |
Removes the manifest ID and updates the consolidated QR code icon path. |
screenly_qc.yml |
Removes the separate QC manifest. |
README.md |
Adds release instructions, a badge, and preview image. Nit: the preview image should use a repository-relative path such as ./screenshots/1920x1080.webp to render correctly. (1 vote) |
package.json |
Updates @screenly/edge-apps to ^1.2.1. |
bun.lock |
Updates dependency resolutions for the Edge Apps upgrade. |
.github/workflows/update-edge-app.yml |
Uses the v26.10.2 reusable workflow for stage and production deployments. |
.github/workflows/initialize-edge-app.yml |
Uses the v26.10.2 reusable initialization workflow. Critical: production initialization can run from a manually dispatched non-main ref; production initialization must remain pinned to main or otherwise be guarded. (2 votes) |
.github/workflows/checks.yml |
Uses the v26.10.2 reusable checks workflow. |
.github/dependabot.yml |
Enables weekly GitHub Actions updates targeting development. |
Review effort: Lite
| edge_app_name: ${{ inputs.edge_app_name }} | ||
| edge_app_title: ${{ inputs.edge_app_title }} | ||
| environment: ${{ inputs.environment }} | ||
| uses: Screenly/edge-apps-actions/.github/workflows/initialize.yml@v26.10.2 |
Merge main into development
There was a problem hiding this comment.
🔵 Needs a closer look
Approval should be deferred because production deployment depends on external workflow configuration and live environment secrets, variables, reviewer rules, and tag rulesets that are not verifiable from the diff.
1 open issue
Review effort: Lite
514sid
approved these changes
Oct 29, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Promotes
developmenttomain. This switches the app's CI to the edge-apps-actions v26.10.2 reusable workflows (Checks, Initialize Edge App, Update Edge App), and brings the README release docs.Important
Merge #18 (
main→development) first. Until then this PR shows conflicts or a brokendevelopment.Changes since
mainAfter merging
main→ deploy to stage, which waits for approval in thestageenvironment.main(vYY.MM.N) and push the tag → deploy to production, which also waits for approval. Tags that aren't onmainare refused.