Repository navigation
chore: update icon path to consolidated icons directory - #3
Merged
Merged
Conversation
Contributor
|
Heads up: this PR currently has merge conflicts with Flagged by an automated PR-hygiene sweep — no action needed beyond the rebase, and no reply expected. |
There was a problem hiding this comment.
🔵 Needs a closer look
The change deletes the entire screenly_qc.yml manifest rather than updating its icon URL, removing configuration required by QC or deployment flows.
No open issues 🎉
What changed in this PR
Updates the app manifests to use the consolidated icons directory. The production manifest is updated correctly, but the QC manifest is deleted instead of having its icon path updated.
Changes:
- Updates
screenly.ymlto reference the consolidated icon path. - Deletes
screenly_qc.yml, removing the QC manifest.
This pull request requires changes.
| File | Review |
|---|---|
screenly.yml |
Updates the manifest to reference the consolidated icon path. |
screenly_qc.yml |
Critical (4 votes): The entire QC manifest was removed. Retain the file and update only its icon URL. |
Review effort: Lite
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
iconfield inscreenly.ymlandscreenly_qc.ymlto point to the new consolidated icons directory.Depends on Screenly/Playground#875.