Repository navigation
Use edge-apps-actions v26.10.2 and add release badge to README - #17
Merged
Merged
Conversation
Deploy stage on pushes to the default branch and production on vYY.M.PATCH tags, refusing tags not on the default branch. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
🟡 Changes recommended
Critical production workflow issues remain unresolved, along with the README image path nit.
3 open issues
What changed in this PR
Updates deployment workflows to newer Edge Apps actions and adds release metadata to the README.
Changes:
- Pins Edge Apps actions to
v26.10.0and checkout tov7. - Routes
maindeployments to stage and version tags to production. - Adds a release badge and preview image to the README.
| File | Summary |
|---|---|
README.md |
Adds release badge and preview image; image path needs correction. |
.github/workflows/update-edge-app.yml |
Updates deployment triggers and action versions; production tag validation has a critical trust-boundary issue. |
.github/workflows/initialize-edge-app.yml |
Updates initialization handling; production runs must remain pinned to main. |
.github/workflows/checks.yml |
Updates the checks action version. |
Review effort: Lite
| with: | ||
| ref: ${{ inputs.environment == 'production' && 'main' || github.ref }} | ||
| - uses: Screenly/edge-apps-actions/initialize@f4ccd2bd50db5fb0a5147d287ac03cafe552d29b | ||
| - uses: Screenly/edge-apps-actions/initialize@v26.10.0 |
|
|
||
| # Screenly Simple Timer App | ||
|
|
||
|  |
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Checks, Initialize and Update now call the reusable workflows; deploys queue instead of running side by side. Dependabot checks GitHub Actions weekly and targets development, so pin bumps go through the usual flow.
salmanfarisvp
changed the title
| steps: | ||
| - uses: actions/checkout@v7 | ||
| - uses: Screenly/edge-apps-actions/checks@v1 | ||
| uses: Screenly/edge-apps-actions/.github/workflows/checks.yml@v26.10.2 |
| edge_app_title: ${{ inputs.edge_app_title }} | ||
| environment: ${{ inputs.environment }} | ||
| edge_app_id: ${{ secrets.EDGE_APP_ID || (inputs.environment == 'production' && vars.PRODUCTION_EDGE_APP_ID || (inputs.environment == 'stage' && vars.STAGE_EDGE_APP_ID)) }} | ||
| uses: Screenly/edge-apps-actions/.github/workflows/initialize.yml@v26.10.2 |
| edge_app_id: ${{ secrets.EDGE_APP_ID || vars.PRODUCTION_EDGE_APP_ID }} | ||
| jobs: | ||
| update: | ||
| uses: Screenly/edge-apps-actions/.github/workflows/update.yml@v26.10.2 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
v26.10.2reusable workflows; deploys queue instead of running side by side, and a running deploy is never cancelled.development.mainstart a stage deploy, av*tag onmainstarts the production deploy (tags not onmainare refused); both wait for approval.maindeploy to stage,v*tags onmaindeploy to production (tags not onmainare refused).Releasingsection documenting the tag-based release (git tag+gh release create).Releasing after merge
Merge into
developmentfirst, then open adevelopment→mainPR. Pushes tomainstart a stage deploy (waits for approval); av*tag onmainstarts the production deploy (also waits for approval).git tag v26.10.0 && git push origin v26.10.0 gh release create v26.10.0 --verify-tag --generate-notes --title v26.10.0