Repository navigation
Type LCM summary inputs and compression policy - #4351
Conversation
|
Co-authored-by: ScriptedAlchemy <25274700+ScriptedAlchemy@users.noreply.github.com>
Co-authored-by: ScriptedAlchemy <25274700+ScriptedAlchemy@users.noreply.github.com>
abd3ded to
247a385
Compare
ScriptedAlchemy
left a comment
There was a problem hiding this comment.
Cross-referenced #4296, #4297, #4298, #4300 and #4305. The typed input/policy migration has one concrete outcome-preservation regression: the existing forced-overflow producer emits a successful response that the new take_outcome rejects. This needs correction before merging; the precise producer and retained transaction path are described inline. This finding is from source/caller tracing, not a completed native test run.
ScriptedAlchemy
left a comment
There was a problem hiding this comment.
Pushed e5aae67 to address the pressure-recovery regression found in review. take_outcome() now accepts completed ok and best_effort responses carrying critical_pressure_catch_up, while malformed authoritative-summary states still fail. Added full wire-response round-trip coverage and a registered retained-pressure recovery regression that reopens the store and verifies summaries were durably committed for both statuses.
Pinned CI rustfmt and git diff --check pass. Native tests have not run locally because this environment exhausted memory on the repository's native dependency build; CI is the execution authority. Marked this PR ready for review because draft PRs explicitly skip the heavy native lane. Relevant coverage is in the LCM unit tests and session-runtime lcm_effects tests. This is an implementation update, not a merge or approval.
…m-replace-json-in-route-summary
The typed outcome conversion accepted any status other than needs_summary when no request or retry marker was present. A malformed decoded result could therefore become Complete despite the closed outcome contract. Match the inventoried ok, best_effort and needs_summary statuses directly. Keep both critical-pressure completion forms and all existing wire fields. Add decoded-invalid-status and valid-completion round-trip regressions. Refs #4298
ScriptedAlchemy
left a comment
There was a problem hiding this comment.
Pushed a3d1c10 for the remaining #4298 outcome-conversion hole. Unknown decoded statuses previously became Complete when no request/retry marker was present; the conversion now accepts only the supported ok, best_effort, and needs_summary combinations. The critical-pressure completion forms remain supported. Added invalid-status and complete-wire round-trip regressions. Pinned rustfmt, whitespace and commitlint pass; native behavior is now with CI.
Read compression responses through a borrowed outcome that accepts the forced-overflow catch-up retry, keep the old route trimming, keep the overflow cap input, and delete the unreachable store-unavailable reason. Pin the request JSON and persisted summary metadata bytes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Summary
The cutover preserves public response fields, token-budget algorithms, route normalization, source/frontier transaction behavior, and metadata bytes.
Verification
-D warnings, clearing the 54 reported fixture type errors.7b96709c451e3b69ff10dd754269809686f2e9adpassed all 421 session integration tests (90.68s) and 167 of 169 native targets. Its remaining failures were the host-handoff fixture's stale generation baseline and the shared heavy-refresh timeout tracked in fix(memory): size and charge text builds in one admission #4393.6c70575ac6a627ea8f864202bb802b1cc0f02d1d, Clippy, the shipped Linux CLI build, repository gates, Dashboard, and feature gates passed; the Linux fleet was still running when the required-check notice arrived. Updated the branch from master (44d8265c13a5feb70e7ea834c1d11ed413f3f2af) to1ed4a0ab365d2a48bae2d232f1237b9bb3018951. Full hosted CI, including the Linux fleet and aggregate, must finish on this new head before merge.Fixes #4296
Fixes #4297
Fixes #4298
Fixes #4300
Fixes #4305