Skip to content

Replace fake registry SDK client in ChatGPT extension with projectless RegistryClient - #4354

Merged
ScriptedAlchemy merged 13 commits into
masterfrom
copilot/simplify-daemon-client-boundary
Oct 21, 2026
Merged

ScriptedAlchemy merged 13 commits into
masterfrom
copilot/simplify-daemon-client-boundary

Conversation

Copilot AI commented Oct 19, 2026 •

Copy link
Copy Markdown
Contributor

The ChatGPT extension now expresses registry reads through an explicit projectless RegistryClient. Registry requests no longer require placeholder endpoint, project ID, or credential values. Operation names and request/result decoders come from the generated SDK operation catalog, and the client uses the existing projectless ServeSession and SDK error classes.

The rekey regressions hold real workers in the existing history fixture while inspecting transferred work. This prevents a worker from consuming a request before its queue-count assertion. Dropped-rekey and readmission handoffs retain exact counts, request/frontier identities, and wake routes. The readmission change is the same validated patch carried from #4391; cancellation starts before releasing its held history pass.

Verification through Bazel:

  • Before the latest master update, the original rekey regression and all 14 registry lifecycle tests passed, covering dropped joins, retirement, readmission, cancellation, panic recovery, and handoffs. Strict Clippy passed for the session-runtime unit-test target.
  • The readmission patch carried from build(bazel): update to 9.3.1 and reuse eval process ownership #4391 passed its focused native test (1 case, 155 filtered) and strict Clippy under Bazel 9.3.1 there. Those identical checks were not duplicated in this lane.
  • Pinned formatting, diff checks, and the commit hook passed after integration. Updated from master before pushing the combined changes.

Full CI on the combined head is pending, including the extension's native daemon journeys; prior-head green checks do not establish readiness for this head.

Refs #4225.

@changeset-bot

changeset-bot Bot commented Oct 19, 2026 •

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: ddf66d2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copilot AI changed the title [WIP] Simplify the daemon client boundary across HTTP and MCP operations Replace fake registry SDK client in ChatGPT extension with projectless RegistryClient Oct 19, 2026
Copilot AI requested a review from ScriptedAlchemy October 19, 2026 04:13
@ScriptedAlchemy
ScriptedAlchemy force-pushed the copilot/simplify-daemon-client-boundary branch from 08926ac to 539a359 Compare October 20, 2026 22:42

@ScriptedAlchemy ScriptedAlchemy left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cross-referenced #4225. The projectless RegistryClient removes the fake project boundary for registry operations, and I found no new concrete correctness defect in that change. It remains a scoped first step: project operations and session ownership are unchanged, while #4225 also requires one documented client/session ownership path, deterministic restart/shutdown behavior, cancellation/concurrent-acquisition conformance, and removal of superseded ownership code.

I changed the PR body's Fixes #4225 to Refs #4225 so merging this slice does not close the remaining boundary work. Review here was source/generated-contract comparison; real-daemon conformance was not run locally.

@ScriptedAlchemy
ScriptedAlchemy marked this pull request as ready for review October 21, 2026 06:25

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 Devin Review: 1 flag

Not posted on this PR by your GitHub settings — view it in Devin Review. (Configure)

Devin Review

@ScriptedAlchemy
ScriptedAlchemy merged commit 44d8265 into master Oct 21, 2026
30 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Simplify the extension's daemon client boundary across HTTP and MCP operations

2 participants