Repository navigation
Replace fake registry SDK client in ChatGPT extension with projectless RegistryClient - #4354
Conversation
|
Co-authored-by: ScriptedAlchemy <25274700+ScriptedAlchemy@users.noreply.github.com>
08926ac to
539a359
Compare
ScriptedAlchemy
left a comment
There was a problem hiding this comment.
Cross-referenced #4225. The projectless RegistryClient removes the fake project boundary for registry operations, and I found no new concrete correctness defect in that change. It remains a scoped first step: project operations and session ownership are unchanged, while #4225 also requires one documented client/session ownership path, deterministic restart/shutdown behavior, cancellation/concurrent-acquisition conformance, and removal of superseded ownership code.
I changed the PR body's Fixes #4225 to Refs #4225 so merging this slice does not close the remaining boundary work. Review here was source/generated-contract comparison; real-daemon conformance was not run locally.
There was a problem hiding this comment.
🔍 Devin Review: 1 flag
Not posted on this PR by your GitHub settings — view it in Devin Review. (Configure)
The ChatGPT extension now expresses registry reads through an explicit projectless RegistryClient. Registry requests no longer require placeholder endpoint, project ID, or credential values. Operation names and request/result decoders come from the generated SDK operation catalog, and the client uses the existing projectless ServeSession and SDK error classes.
The rekey regressions hold real workers in the existing history fixture while inspecting transferred work. This prevents a worker from consuming a request before its queue-count assertion. Dropped-rekey and readmission handoffs retain exact counts, request/frontier identities, and wake routes. The readmission change is the same validated patch carried from #4391; cancellation starts before releasing its held history pass.
Verification through Bazel:
Full CI on the combined head is pending, including the extension's native daemon journeys; prior-head green checks do not establish readiness for this head.
Refs #4225.