Repository navigation
fix(sessions): rediscover refreshes superseded by reset - #4455
Merged
Merged
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A session reset can supersede an in-flight refresh without advancing its observation frontier. The stale candidate then fails, and the scheduler's unchanged-input suppression prevents its replacement indefinitely.
Return a typed reset-superseded error from completion and allow rediscovery after that candidate fails durably. Ordinary deterministic failures retain suppression. The regression runs the real scheduler worker and verifies automatic replacement, exactly one active generation, consumed reset, and absence of retired output. A second case verifies that an unchanged ambiguous input still fails only once across another wake.
Validation: the real worker regression failed on the prior implementation. After integration onto master, all 26 projection tests and 24 temporal refresh runtime tests passed. All four affected formatter targets passed on byte-identical source files. Independent source and comment reviews passed. No timeout was increased.
Follow-up to #4381.