Skip to content

WIP2 - #2020

Draft
charlespwd wants to merge 17 commits into
cp-one-parserfrom
cp-expression-refactor
Draft

WIP2#2020
charlespwd wants to merge 17 commits into
cp-one-parserfrom
cp-expression-refactor

Conversation

@charlespwd

@charlespwd charlespwd commented Dec 3, 2025

Copy link
Copy Markdown
Contributor

Architectural changes

  • parse_expression and safe_parse_expression have been removed from Tag and ParseContext
  • Parser methods now produce AST nodes instead of strings
    • Parser#expression produces a value,
    • Parser#string produces a string,
    • etc.

Breaking changes

  • Parser#expression is renamed to Parser#expression_string
  • safe_parse_expression methods are replaced by Parser#expression
  • parse_expression methods are replaced by Parser#unsafe_parse_expression

@charlespwd
charlespwd force-pushed the cp-expression-refactor branch from 9e95ad0 to 5e3d8f4 Compare December 3, 2025 17:46
@charlespwd
charlespwd force-pushed the cp-expression-refactor branch from 5e3d8f4 to 34101f9 Compare January 12, 2026 16:56
@charlespwd
charlespwd force-pushed the cp-expression-refactor branch from 34101f9 to 806c613 Compare January 14, 2026 14:57
@charlespwd
charlespwd force-pushed the cp-expression-refactor branch 2 times, most recently from 1cb61d0 to 6f03452 Compare January 27, 2026 15:00
charlespwd and others added 16 commits October 26, 2026 20:57
@charlespwd
Remove warnings system
5fd6898
@charlespwd
Move safe_parse_expression into Parser.expression_node
fc352ee 
- Make `Parser` accept the expression cache
- Remove `safe_parse_expression` from `ParseContext`
- Replace all usage of `safe_parse_expression` with `parser.expression_node`
@charlespwd
Move parse_expression to Parser.unsafe_parse_expression
90a6d2d 
- Add Parser#string
- Add Parser#unsafe_parse_expression
- Add private Parser#parse_expression
- Remove ParseContext.parse_expression
- Remove Tag.parse_expression
- Condition.parse_expression now takes a parser as argument
@charlespwd
Rename Parser#expression -> Parser#expression_string
32b8a2b
@charlespwd
Rename Parser#argument -> argument_string
8bd6599
@charlespwd
Rename Parser#expression_node -> Parser#expression
cab7fe9
@charlespwd
Remove Expression#safe_parse
1f0154d
@charlespwd
Extract Parser#string out of Expression.parse
f3b12af
@charlespwd
Extract Parser#number parse out of Expression.parse
42dfd70
@charlespwd
Simplify parse_number
69ea2c5 
We don't need all the multi-dot logic in a world where number comes
out of the Lexer.
@charlespwd
Replace RangeLookup.parse with RangeLookup.create
d5f6319
@charlespwd
Move VariableLookup parsing logic to .parse instead of initializer
c1eb6f0 
Goal is to get rid of it entirely, but baby steps.
@charlespwd
Extract Parser#variable_lookup out of Expression.parse
828d9f2
@charlespwd
Extract Parser#range_lookup out of Expression.parse
63a813f
@charlespwd
Replace Context[]'s Expression.parse with Parser#expression
10bd2a5
@charlespwd @claude
fix(case): use Condition.parse_expression for empty/blank handling
7c0cf59 
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@charlespwd @claude
style: fix rubocop offenses
6519af8 
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@charlespwd
charlespwd force-pushed the cp-expression-refactor branch from 6f03452 to 6519af8 Compare October 27, 2026 01:12
@charlespwd
charlespwd added this pull request to stack #2135 October 27, 2026 18:07

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

#gsd:48203

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@charlespwd