Skip to content

Match ActiveSupport for Unicode whitespace in the blank emulation #2131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sebxt wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Match ActiveSupport for Unicode whitespace in the blank emulation #2131

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/liquid/condition.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,7 @@ def liquid_blank?(value)
false
when String
# Blank if empty or whitespace only (matches ActiveSupport)
value.empty? || value.match?(/\A\s*\z/)
value.empty? || value.match?(/\A[[:space:]]*\z/)
when Array, Hash
value.empty?
else
Expand Down
11 changes: 11 additions & 0 deletions test/unit/condition_unit_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,6 +219,17 @@ def test_blank_with_whitespace_string
assert_evaluates_true(VariableLookup.new('whitespace'), '==', blank_literal)
end

def test_blank_with_unicode_whitespace_string
# ActiveSupport's String#blank? matches /\A[[:space:]]*\z/, so Unicode
# whitespace such as a non-breaking space or an ideographic space is blank.
blank_literal = Condition.class_variable_get(:@@method_literals)['blank']

["\u00A0", "\u3000", "\u2003 \n"].each do |value|
@context['unicode_whitespace'] = value
assert_evaluates_true(VariableLookup.new('unicode_whitespace'), '==', blank_literal)
end
end

def test_blank_with_empty_string
# An empty string has no content, so it should be considered blank.
# This is the most basic case of a blank string.
Expand Down
Loading