Repository navigation
Fix CI: quote Ruby matrix versions, add 3.4, bump Bundler pin to 2.4.22 - #98
Merged
Merged
Conversation
Every CI run since December 2024 fails before tests start, in the job labelled "Ruby 3". Two things combined: 1. The matrix lists Ruby versions as unquoted YAML numbers (Shopify#53, 2021). YAML reads 3.0 as the number 3, so setup-ruby installs the latest 3.x, not Ruby 3.0. Harmless until 3.x meant 3.4. 2. Gemfile.lock pins Bundler 2.2.33 (7cb1151, June 2024), whose vendored Thor references DidYouMean::SPELL_CHECKERS. Ruby 3.4 ships did_you_mean 2.0.0, which removed that constant, so Bundler 2.2.33 crashes on load under Ruby 3.4. setup-ruby v1.206.0 (2024-12-26) added Ruby 3.4.0. From then on "3" meant 3.4, Bundler 2.2.33 crashed, and fail-fast cancelled the other jobs, so no Ruby reported a result. Changes: quote the matrix versions; add Ruby 3.4; fail-fast: false; bump the Bundler pin to 2.4.22 (newest that installs on Ruby 2.7 and loads on 3.4); actions/checkout v2 -> v4. Verified locally: Bundler 2.2.33 reproduces the CI NameError on Ruby 3.4.9; with 2.4.22 the suite passes on Ruby 3.4.9 and 4.0.7.
aminpaks
reviewed
Sep 29, 2026
aminpaks
reviewed
Sep 29, 2026
aminpaks
requested changes
Sep 29, 2026
sjahu
approved these changes
Sep 30, 2026
The CI matrix now quotes its Ruby versions, so the job previously named "Ruby 3 Gemfile" is "Ruby 3.0 Gemfile", and 3.4 was added. The required-check list in shipit.rubygems.yml still named the old jobs (and 2.4/2.5/2.6, which have not existed for years), so Shipit would find none of them on a release commit. List the six current job names.
sjahu
approved these changes
Sep 30, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix CI: every run has failed before tests start since December 2024