Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: Convert the executable check and graph specs from YAML to TOML, preserving all cases and their fixture contents, expected diagnostics, fixes, and graph edges.
Overview
#1347 introduced the shared check and graph specs in YAML. This converts its 98 spec and docset files to TOML. Their fixtures pin source ranges and fixes, so preserving whitespace is part of preserving behavior.
Approach
Both Vitest runners now discover
.tomlfiles and parse them withsmol-toml, including the shared check docset. Simple lists such as docset filters and graph modules use compact arrays of inline tables. Fixtures use literal multiline strings for readable quotes and backslashes, with basic multiline strings and escapes where needed to preserve trailing spaces. The check and graph READMEs explain these conventions and table scoping rules.scripts/verify-spec-conversion.mjscompares the TOML files with the YAML at a selected Git revision. It checks that every YAML file has exactly one replacement, then compares all parsed data, including fixture whitespace. This gives reviewers a repeatable way to check the conversion beyond running the suites.Start reviewing here:
Tophat
From this PR's branch at the repository root, install dependencies and build the workspace packages used by the tests:
Run the repository's comparison tool against the revision before this conversion:
Observed output:
Run the unit suite and static checks:
pnpm exec vitest run pnpm type-check pnpm format:checkThe full suite passed: 282 test files, 9,535 tests passed, and 5 skipped. The converted spec runners passed all 1,799 tests, matching the YAML baseline. The TypeScript build, type checks, and formatting checks also passed.