Repository navigation
Keep Reader auth mounted and dedupe concurrent One Tap startup - #91
Merged
Merged
Conversation
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
reader | ebc4261 | Oct 14 2026, 08:05 AM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reader's login could remount its auth subtree as its dynamic client module loaded, and concurrent Google One Tap calls could initialize the prompt twice. This keeps the provider and its children mounted through auth updates, coalesces in-flight One Tap initialization, and shows a clear fallback message in the existing login card while the standard Google sign-in action remains available. Internal failure details still go to the existing auth-failure telemetry.
The branch preserves the exact frozen cloud source commit
9b3ff97ba67349e68b7001d89e80b4c20a7309cf(tree52c8503866257f9c306456a13daaff584629fed7) as an ancestor of current headebc42618eca8b6206232c361af52ca7c6c5935ad. It was imported from a SHA-verified Git bundle on currentmain(4c45b25, merged PR #89). Local follow-ups make the browser fixture cross-browser and keep the user-facing message in product language. No credentials, provider settings, or production configuration changed.Validation: frozen install and full
pnpm qualitypassed (96 unit tests, app/extension builds, code-health gates). Exact-head CI and the externalWorkers Builds: readercheck both passed. The localcf:buildpreview and One Tap failure/recovery replay passed on desktop, tablet, and mobile. Rendered phone and desktop login states preserve the current design without overflow.Source review is ready. Merge remains held: the Cloudflare check points to a
reader/production/buildstarget, and the available GitHub/provider evidence does not establish whether mergingmaincan publish production. The provider dashboard redirects to sign-in. This needs the owner's public-release approval before merge; production behavior is unverified.Refs #90 and sass-maker/saas-maker#243.