Repository navigation
Zigbee/Zwave: Add explicit index mins for lock capability defs - #3305
Closed
hcarter-775 wants to merge 2 commits into
Closed
hcarter-775 wants to merge 2 commits into
hcarter-775 wants to merge 2 commits into
Conversation
|
Channel deleted. |
|
zigbee-lock_coverage.xml
Minimum allowed coverage is Generated by 🐒 cobertura-action against 581819e |
|
zwave-lock_coverage.xml
Minimum allowed coverage is Generated by 🐒 cobertura-action against 581819e |
Test Results 73 files 545 suites 0s ⏱️ Results for commit 581819e. ♻️ This comment has been updated with latest results. |
ctowns
reviewed
Oct 27, 2026
| capability = capabilities.lockCredentials, | ||
| attribute = capabilities.lockCredentials.credentials, | ||
| max_entries = capabilities.lockCredentials.pinUsersSupported, | ||
| minimum = 0, |
Contributor
There was a problem hiding this comment.
Before making this change, we also need to make sure that we sync the master codes from devices that already have them but either weren't present before migration or weren't synced when onboarding to the new lock experience. Otherwise the driver will see that slot 0 is available and we would have failures when writing to that index if that slot already exists but we just hadn't synced it to our capabilities yet.
Contributor
|
Do we need to decouple credential index and user index in the auto case here? |
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
hcarter-775
force-pushed
the
add/explicit-lock-mins
branch
from
October 28, 2026 17:48
62294d5 to
581819e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
In Zigbee, the minimum for PIN code indices starts at 0, not 1, which was previously being skipped even though it is an allowed value. This change makes that allowable, and makes the minimum handling for other index values more explicit (though the rest were, correctly, 1).
Summary of Completed Tests
Unit tests continue to pass.