Repository navigation
Validate zigbee/zwave lock migraton indices - #3307
Closed
hcarter-775 wants to merge 3 commits into
Closed
hcarter-775 wants to merge 3 commits into
hcarter-775 wants to merge 3 commits into
Conversation
|
Channel deleted. |
|
zwave-lock_coverage.xml
Minimum allowed coverage is Generated by 🐒 cobertura-action against a39b20a |
|
zigbee-lock_coverage.xml
Minimum allowed coverage is Generated by 🐒 cobertura-action against a39b20a |
Test Results 73 files ±0 545 suites ±0 0s ⏱️ ±0s For more details on these failures, see this check. Results for commit a39b20a. ± Comparison against base commit 62294d5. ♻️ This comment has been updated with latest results. |
Drop legacy lockCodes slots that are not valid credential indices when migrating to lockUsers/lockCredentials. A valid credential slot that is not a valid userIndex (slot 0) is given the lowest unused userIndex without displacing any slot that is already valid. Add tables.get_minimum to read a table's minimum index, and tests for deleting credentials whose user or credential index maps to no entry. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Drop legacy lockCodes slots that are not valid credential indices (such as 0, which means "all users" in Z-Wave) when migrating to lockUsers/lockCredentials. Remaining users are numbered sequentially from 1. Add tables.get_minimum to read a table's minimum index, and tests for deleting credentials whose user or credential index maps to no entry. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
hcarter-775
force-pushed
the
fix/validate-lock-migration-indices
branch
from
October 28, 2026 17:47
6118f97 to
a39b20a
Compare
hcarter-775
force-pushed
the
add/explicit-lock-mins
branch
from
October 28, 2026 17:48
62294d5 to
581819e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Validate lock migration indices for Zigbee and Zwave, to ensure that only valid entries are actually written. This is especially useful for ensuring that the Zwave credential 0 is never applied after the migration, since it a special value with "delete all" capabilities, and for ensuring that all user indices are >=1, since that is the capability defined minimum.
Summary of Completed Tests
Unit tests added that ensures validation is handled correctly, and that credential deletions for invalid cred indices work as expected (we want to ensure these orphan values can be removed as expected).