Repository navigation
Matter Switch: add default fingerprint tables to profiling logic - #3316
Open
hcarter-775 wants to merge 1 commit into
Open
hcarter-775 wants to merge 1 commit into
hcarter-775 wants to merge 1 commit into
Conversation
|
Invitation URL: |
|
matter-switch_coverage.xml
Minimum allowed coverage is Generated by 🐒 cobertura-action against a5831fc |
Test Results 73 files 546 suites 0s ⏱️ Results for commit a5831fc. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
The Matter Switch driver currently skips dynamic profiling for every device that is assigned the generic light-color-level or light-level-colorTemperature profile. The skip exists to protect devices certified on profiles with embedded Kelvin ranges, which would lose those ranges if re-profiled. As written it is far too broad. It also blocks new and unlisted color lights from being profiled correctly.
Summary of Completed Tests
Unit tests updated, and a new unit test has been added to show the deprecated profile table override in action. Tested on-device to show backwards compatibility (device that does not use the override table).