Skip to content

zwave lock: ensure the "wildcard" 0 index is implemented safely - #3317

Open
hcarter-775 wants to merge 1 commit into
mainfrom
zwave-lock-wildcard-index-safety
Open

hcarter-775 wants to merge 1 commit into
mainfrom
zwave-lock-wildcard-index-safety

Conversation

@hcarter-775

Copy link
Copy Markdown
Contributor

Description of Change

Per the Zwave spec: "The value 0 MUST indicate that the receiving node MUST set the User Code and User Status for all
supported User Identifiers. The value 0 MUST be used only with User ID Status set to 0x00.". This means that:

  1. a user code can never be stored on slot 0, which is already handled normally.
  2. no update user command should work, and should in fact return an invalid status, rather than the generic failure it would have returned before
  3. we should only allow all credentials to be deleted in one go via the explicit "delete all credentials" command. It is therefore safer to use this 0 wildcard in that case, and to make a deleteCredential command using the 0 slot as a parameter invalid.

Summary of Completed Tests

Unit tests updated. Waiting on live E2E test validating this.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@github-actions

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant