Repository navigation
Zwave lock: let Schlage masked code reports advance credential sync - #3318
Open
hcarter-775 wants to merge 1 commit into
Open
hcarter-775 wants to merge 1 commit into
hcarter-775 wants to merge 1 commit into
Conversation
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
|
Invitation URL: |
Test Results 73 files 546 suites 0s ⏱️ Results for commit db690b0. |
|
zwave-lock_coverage.xml
Minimum allowed coverage is Generated by 🐒 cobertura-action against db690b0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
The new sync functionality added to the Zwave Lock driver with the migration work did not work for Schlage as written, see the issue here. This is because the Get response that the sync keys on is overwritten for Schlage. To allow Schlage devices to do syncing, we just need to add a sync codes in-progress check.
Summary of Completed Tests
Unit test added. Tested on-device by reporter.