Repository navigation
Add solid-panes webpack aliases - #470
Merged
Merged
Conversation
…6.0.0 solid-ui@5.0.1 pane-registry@5.0.1 solid-panes@5.0.0)
Contributor
There was a problem hiding this comment.
Copilot review overview
🔵 Needs a closer look
Build and watch compatibility across package and workspace modes still needs dependency-enabled verification.
Review effort: Balanced
Findings: None
What changed in this PR
Aligns Mashlib’s solid-panes resolution with the ESM-only watch output introduced by toolkit #9.
Changes:
- Adds an exact-match ESM alias for the installed
solid-panespackage. - Adds the corresponding alias for the sibling workspace checkout.
| File | Description |
|---|---|
| webpack.config.mjs | Routes solid-panes imports to ESM output in both resolution modes. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
bourgeoa
approved these changes
Oct 7, 2026
timea-solid
approved these changes
Oct 7, 2026
timea-solid
left a comment
timea-solid
left a comment
Member
There was a problem hiding this comment.
In general this shoudl be fine.
I build and run SolidOS from staging without problems... I did have to modify a bit the watch-pivot script for it.. pushed it to main branch of SolidOS.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@bourgeoa I was hoping you could check this. Do you think it is okay and will build properly with this change?
I had to make these changes to the toolkit SolidOS/toolkit#9 because the watch-pivot won't work without them. I have all my solidos repos pointing to the changed toolkit and I had a problem with solid-panes in mashlib build that this fix resolved.
I don't want to merge the toolkit until you give your okay to make the change here.