Skip to content

fix: only push enterprise release images to ECR - #92

Merged
mamundsen-specter merged 1 commit into
mainfrom
feat/BI-2025
Oct 7, 2026
Merged

mamundsen-specter merged 1 commit into
mainfrom
feat/BI-2025

Conversation

@mamundsen-specter

@mamundsen-specter mamundsen-specter commented Oct 7, 2026 •

Copy link
Copy Markdown
Collaborator

Summary by CodeRabbit

  • Chores
    • Container build publishing now uses Amazon ECR only for non-prerelease enterprise builds. Docker registry image naming remains available for all builds.
    • AWS credential setup and Amazon ECR login are limited to non-prerelease enterprise builds.

@coderabbitai

coderabbitai Bot commented Oct 7, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Essentials
  • Run ID: f5b776da-1271-43fa-bc1d-d8a979b3008f
📥 Commits

Reviewing files that changed from the base of the PR and between 61e3dd3 and bcc5aab.

📒 Files selected for processing (1)
  • .github/workflows/build-and-sign-container.yml

Included review availability: This review used your included allowance. 4 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour.


Walkthrough

The container build workflow now enables the ECR image name and runs AWS credential configuration and Amazon ECR login only for non-prerelease enterprise builds. The Docker registry image name remains enabled for all builds.

Changes

Container registry conditions

Layer / File(s) Summary
Registry naming and AWS setup conditions
.github/workflows/build-and-sign-container.yml
The ECR image name and AWS setup steps now require a non-prerelease enterprise build. The Docker registry image name remains unconditional.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~8 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to bcc5a

The automated release workflow continues Docker publishing and limits ECR to non-prerelease enterprise releases. No actionable merge risk from this change is established.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the change: only enterprise release images are pushed to ECR.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

A rabbit checks the build’s ECR gate
Enterprise runs; prereleases wait
Docker naming stays in place
AWS steps follow the same case
The workflow hops along its way

Comment @coderabbitai help to get the list of available commands.

@mamundsen-specter
mamundsen-specter merged commit 4727501 into main Oct 7, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants