Repository navigation
OpenEphys: check channel maps on same signal chain as NP probe - #471
Merged
alejoe91 merged 5 commits intoOct 13, 2026
Merged
Conversation
Member
|
I am a bit ost in this XML from openephys but I trust you. |
samuelgarcia
approved these changes
Oct 13, 2026
…fix-multiple-signal-chains
for more information, see https://pre-commit.ci
chrishalcrow
approved these changes
Oct 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue when there are multiple signal chains (e.g. 2 sources) and there is a channel map in a signal chain different than the one with the Neuropixels probe.
We had logic to apply the esixting channel map, but it was not checking if the channel map was actually applied to the NP probe or other sources!
This PR fixes it by keeping a signal chain index for the NP_PROBE and CHANNEL_MAP processors and only applies the mapping if they match. Added a test file and a small test for this new fix.