Repository navigation
Conversation
alejoe91
approved these changes
Oct 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I got this error on #4840 (Filter one channel at a time to reduce peak memory) and decided to fix it here. When we changed
set_probe()andset_probegroup()to modify the recording in place, calls withoutin_placestopped returning a recording. The fixture builders account for removing the argument but still assign the return value torec_with_probe. That value isNone, so the script fails when it tries to save the recording.This was working before because the script uses
in_place=Falsefor versions up to and including 0.105.0. That release still supports the deprecated argument and returns a recording in that case. The workflow automatically selects the latest published patch of each minor version. Once 0.105.1 was published, it selected the other path in the script and exposed the incorrect return-value assumption. The in-place behavior was already present in 0.105.0. It was the version selected by the workflow that changed.This PR keeps the original recording after attaching the probe in the newer-version paths. The older-version paths are unchanged. I checked fixture generation and all 26 round trips separately with 0.105.0 and 0.105.1, including parallel binary and Zarr writes.