Repository navigation
feat: multi-signer mempool, block packaging and RPC for generalized transactions - #165
Open
SIDDHANTCOOKIE wants to merge 1 commit into
Open
SIDDHANTCOOKIE wants to merge 1 commit into
SIDDHANTCOOKIE wants to merge 1 commit into
Conversation
…alized txs Mempool tracks every (signer, nonce) slot for ordering, replace-by-fee and purging after a block. The block builder no longer assumes a single sender, mc_sendTransaction reports malformed or partially signed payloads, and mc_getNonce is added.
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. 🗂️ Base branches to auto review: 2
Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
SIDDHANTCOOKIE
added this pull request to stack #158
October 19, 2026 06:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PR 3 of the generalized transaction roadmap (stacked on #164). Makes the mempool, block builder and RPC work with multi-party transactions.
Changes
minichain/mempool.py)(signer, nonce)slot intx.nonces.remove_transactions()purges every pending transaction that shares a spent(signer, nonce)slot with a mined one.main.py)validate_and_applyalready rejects stale nonces for every signer.minichain/rpc.py)mc_sendTransactionreturns clear errors for malformed payloads and for transactions missing a required signature.mc_getNonce(address)returns the account nonce without creating the account.Not in this PR
CLI co-signing, passing partially signed transactions between co-signers, and README/example docs. These come in the next PR.
Test Plan
tests/test_generalized_mempool.py(10 tests): partial signatures, conflicts on any signer, outbidding every conflict, cross-signer ordering, contradictory ordering, purge after mining, mining a two-party swap into a block, and the RPC cases.