Repository navigation
feat: mc_getStorage RPC, deploy prints contract address, DEX docs - #170
Open
SIDDHANTCOOKIE wants to merge 1 commit into
Open
SIDDHANTCOOKIE wants to merge 1 commit into
SIDDHANTCOOKIE wants to merge 1 commit into
Conversation
mc_getStorage returns a contract's storage (e.g. the batch-auction order book) without creating the account. The CLI deploy command now prints the derived contract address, which was otherwise not shown anywhere. README documents the batch-auction DEX flow.
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. 🗂️ Base branches to auto review: 2
Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
SIDDHANTCOOKIE
added this pull request to stack #158
October 21, 2026 06:58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Phase 3, PR 2 (stacked on #169). This makes the batch-auction DEX usable from the CLI and RPC, and documents it.
Changes
mc_getStorage(address)RPC (minichain/rpc.py): returns a contract's storage, such as the DEX's open orders and its last clearing price and volume. An unknown address returns{}without creating an account. It's a generic method, so it works for any contract, not only the DEX.deployprints the contract address (main.py). Until now the CLI never showed it, andbalancecuts addresses down to 12 characters, so there was no way to find the address to call. It's computed the same way the chain derives it (sender + nonce).README: a "Batch-Auction DEX" section covering:
mc_getStoragemc_getStorageis added to the RPC list.No new CLI commands: the existing
callalready sends multi-asset value as JSON.Test Plan
tests/test_rpc.py::test_rpc_getStoragechecks three things:{}and isn't createdshlex+parse_tx_params), mining a real block after each step: