Repository navigation
Conversation
…d the security domain
Prometee
approved these changes
Oct 8, 2026
NoResponseMate
approved these changes
Oct 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The login error template runs
messageKey|transwith no parameters and the default domain, so Symfony's security messages never get their placeholders filled or their translations picked up. Withlogin_throttlingon, an admin sees the raw key:Fixes:

Too many failed login attempts, please try again in %minutes% minute.Too many failed login attempts, please try again in 1 minute.Same story for every non-English locale:
Invalid credentials.stays in English, because the translation lives in thesecuritydomain. The template now follows what the Symfony docs show for login forms,error.messageKey|trans(error.messageData, 'security').FrenchTranslatedLoginTestcovers the domain part (fails before, passes after underAPP_LOCALE=fr). The%minutes%part needslogin_throttling, which the test app doesn't enable, as it would pull insymfony/rate-limiterjust for this.