Repository navigation
[BootstrapAdminUi] Fall back to the default label and icon of the grid delete action - #391
Merged
Merged
Conversation
crydotsnake
approved these changes
Oct 9, 2026
loic425
approved these changes
Oct 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
With
symfony/ux-twig-component3.5, an explicitnullpassed to a{% props %}prop no longer falls back to its default value.The grid delete action passes
action.labelandaction.icondirectly to thesylius_bootstrap_admin_ui:delete_modalcomponent. When these values are not configured, they arenull, resulting in a missing delete icon, an empty tooltip, and an empty confirmation button label.Fix
Apply explicit fallbacks in the shared grid delete action template, matching the component's defaults:
sylius.ui.deletetabler:trash-xCustom labels and icons remain unchanged.
This backports the relevant fix from Sylius/Sylius#19285 to Sylius Stack, so applications using BootstrapAdminUi benefit from it directly, including those using Asset Mapper.