Skip to content

[BootstrapAdminUi] Fall back to the default label and icon of the grid delete action - #391

Merged
loic425 merged 1 commit into
Sylius:mainfrom
Prometee:fix/grid-delete-action-defaults
Oct 9, 2026
Merged

loic425 merged 1 commit into
Sylius:mainfrom
Prometee:fix/grid-delete-action-defaults

Conversation

@Prometee

@Prometee Prometee commented Oct 9, 2026

Copy link
Copy Markdown
Contributor
Q A
Branch? main
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Related tickets Backports Sylius/Sylius#19285
License MIT

Problem

With symfony/ux-twig-component 3.5, an explicit null passed to a {% props %} prop no longer falls back to its default value.

The grid delete action passes action.label and action.icon directly to the sylius_bootstrap_admin_ui:delete_modal component. When these values are not configured, they are null, resulting in a missing delete icon, an empty tooltip, and an empty confirmation button label.

Fix

Apply explicit fallbacks in the shared grid delete action template, matching the component's defaults:

  • Label: sylius.ui.delete
  • Icon: tabler:trash-x

Custom labels and icons remain unchanged.

This backports the relevant fix from Sylius/Sylius#19285 to Sylius Stack, so applications using BootstrapAdminUi benefit from it directly, including those using Asset Mapper.

@loic425
loic425 merged commit 06e1cec into Sylius:main Oct 9, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants