Repository navigation
Conversation
…f the resource id
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CRUD form decides between POST and PUT by looking at
form.vars.data.id. A resource whose id is assigned in the constructor (UUID/ULID generated up front) already has an id on the create page, so the create form gets<input name="_method" value="PUT">. Withhttp_method_overrideon, the submit hits the create route as PUT and fails with a 405.The page knows which operation it renders, so
crud/create.html.twigandcrud/update.html.twignow passform_methodin the hook context and the form template reads it. Precedence staysconfiguration.method(hookable config) first. The id check remains only as a fallback for apps that override the page templates and don't passform_method.FormMethodTestcovers it: the test app'sBookResourcecreate operation now uses a factory that presets the id. The test fails before the change and passes after it.