Repository navigation
fix: send an empty compound with keyboard clicks - #24
Conversation
nightcore parses every custom click payload as a compound tag, so the
"0b" payload logged a stack trace for each keyboard press on main.
The keyboard never reads the payload; "{}" keeps the clicks the same.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Summary
Merge Risk: ⚪ Minimal · up to Click routing remains unchanged, and no concrete merge-blocking issue was established. The exact NightCore parser behavior could not be confirmed from this repository.
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@coderabbitai review |
✅ Action performedReview finished.
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
1 participant
nightcore 2.13.2
PaperDialogListenerparses the payload of everyPlayerCustomClickEventas a compound tag. The keyboard sent"0b", so each note, chord or options click loggedExpected compound tag at position 2: 0bwith a stack trace (815 times on main on 2026-10-10).The keyboard ignores the payload (it only reads the click key), so this sends
"{}"instead. Tests assert the payload on every cell and the options button.mvn verify: tests and coverage checks pass.