Skip to content

perf: share decoded note names and skip redundant project parses - #29

Merged
Nowkoo merged 1 commit into
fix/multitrack-recording-bugsfrom
perf/studio-note-memory
Oct 11, 2026
Merged

Nowkoo merged 1 commit into
fix/multitrack-recording-bugsfrom
perf/studio-note-memory

Conversation

@Nowkoo

@Nowkoo Nowkoo commented Oct 11, 2026

Copy link
Copy Markdown
Contributor

Stacked on #28.

Decoded notes now share one copy of each instrument and sample name. A song repeats a few dozen names across thousands of notes, and each note used to hold its own copies.

  • Measured with a 7,500-note project (TF Main limits: 4 × 1,500 notes plus a 1,500-note take): heap drops from about 1.11 MB to 0.22 MB. This applies to every project cached for an online player, the 64 cached editions, and every listing.
  • Saves check the legacy single-project layout once per owner. Before, every save and every 10-second checkpoint parsed the whole selected file first, about 40 ms of a 94 ms save.
  • The note sample-name pattern is compiled once instead of per note.
  • Publishing checks audibility directly instead of building a full playback timeline.

Validation: Java 21 mvn clean verify, 285 tests, 100% instruction and branch coverage.

🤖 Generated with Claude Code

Decoded notes now share one copy of each instrument and sample name,
cutting a 7,500-note project from about 1.1 MB to 0.2 MB of heap. Saves
check the legacy single-project layout once per owner instead of parsing
the selected file on every save and checkpoint. The sample-name pattern
is compiled once, and publishing checks audibility without building a
full timeline.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Oct 11, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 4feb9078-dabb-4b40-90ae-26990e5815ac

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added the size:M 30-99 effective changed lines (tests excluded in mixed PRs). label Oct 11, 2026
@Nowkoo

Nowkoo commented Oct 11, 2026

Copy link
Copy Markdown
Contributor Author

Consolidated into #28.

@Nowkoo
Nowkoo merged commit a2ea57e into fix/multitrack-recording-bugs Oct 11, 2026
2 checks passed
@Nowkoo
Nowkoo deleted the perf/studio-note-memory branch October 11, 2026 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M 30-99 effective changed lines (tests excluded in mixed PRs).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant